All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] usb: s3c-otg: Fix remaining bytes in debug messages
Date: Thu, 21 Apr 2016 12:05:25 +0200	[thread overview]
Message-ID: <20160421120525.1ef62557@amdc2363> (raw)
In-Reply-To: <1461050221-9268-4-git-send-email-rogerq@ti.com>

Hi Roger,

> Remaining bytes means bytes that are not yet transferred
> and not the bytes that were transferred in the last transfer.
> 
> Reported-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
> b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c index a31d875..0594c3d
> 100644 --- a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
> +++ b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
> @@ -235,7 +235,7 @@ static void complete_rx(struct dwc2_udc *dev, u8
> ep_num) "%s: RX DMA done : ep = %d, rx bytes = %d/%d, "
>  		   "is_short = %d, DOEPTSIZ = 0x%x, remained bytes =
> %d\n", __func__, ep_num, req->req.actual, req->req.length,
> -		   is_short, ep_tsr, xfer_size);
> +		   is_short, ep_tsr, req->req.length -
> req->req.actual); 
>  	if (is_short || req->req.actual == req->req.length) {
>  		if (ep_num == EP0_CON && dev->ep0state ==
> DATA_STATE_RECV) { @@ -292,7 +292,7 @@ static void complete_tx(struct
> dwc2_udc *dev, u8 ep_num) "%s: TX DMA done : ep = %d, tx bytes =
> %d/%d, " "is_short = %d, DIEPTSIZ = 0x%x, remained bytes = %d\n",
>  		__func__, ep_num, req->req.actual, req->req.length,
> -		is_short, ep_tsr, xfer_size);
> +		is_short, ep_tsr, req->req.length - req->req.actual);
>  
>  	if (ep_num == 0) {
>  		if (dev->ep0state == DATA_STATE_XMIT) {

Acked-by: Lukasz Majewski <l.majewski@samsung.com>

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  reply	other threads:[~2016-04-21 10:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-19  7:16 [U-Boot] [PATCH 0/3] s3c-otg: fastboot: fixes and cleanup Roger Quadros
2016-04-19  7:16 ` [U-Boot] [PATCH 1/3] fastboot: Clean up bulk-out logic Roger Quadros
2016-04-19  9:00   ` Lukasz Majewski
2016-04-21 10:03   ` Lukasz Majewski
2016-04-22  2:59     ` Steve Rae
2016-04-22  3:52       ` Lukasz Majewski
2016-04-19  7:17 ` [U-Boot] [PATCH 2/3] usb: s3c-otg: Fix short packet for request size > ep.maxpacket Roger Quadros
2016-04-19  9:02   ` Lukasz Majewski
2016-04-19 10:21     ` Roger Quadros
2016-04-19 11:25       ` Lukasz Majewski
2016-04-19 11:52         ` Roger Quadros
2016-04-19 12:20   ` [U-Boot] [PATCH v2 " Roger Quadros
2016-04-21 10:04     ` Lukasz Majewski
2016-04-19  7:17 ` [U-Boot] [PATCH 3/3] usb: s3c-otg: Fix remaining bytes in debug messages Roger Quadros
2016-04-21 10:05   ` Lukasz Majewski [this message]
2016-04-22  2:49     ` Steve Rae
2016-04-22  3:03       ` Steve Rae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160421120525.1ef62557@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.