From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751614AbcDUNTd (ORCPT ); Thu, 21 Apr 2016 09:19:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:50214 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbcDUNTb (ORCPT ); Thu, 21 Apr 2016 09:19:31 -0400 Date: Thu, 21 Apr 2016 15:19:25 +0200 From: Jan Kara To: Joe Perches Cc: Sergey Senozhatsky , Andrew Morton , Jan Kara , Petr Mladek , Tejun Heo , Tetsuo Handa , linux-kernel@vger.kernel.org, Byungchul Park , Sergey Senozhatsky Subject: Re: [PATCH v11 0/3] printk: Make printk() completely async Message-ID: <20160421131925.GA30087@quack2.suse.cz> References: <1460050307-3718-1-git-send-email-sergey.senozhatsky@gmail.com> <20160416025529.GA567@swordfish> <1460785489.19090.71.camel@perches.com> <20160421021440.GB655@swordfish> <1461205033.1918.6.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1461205033.1918.6.camel@perches.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 20-04-16 19:17:13, Joe Perches wrote: > On Thu, 2016-04-21 at 11:14 +0900, Sergey Senozhatsky wrote: > > On (04/15/16 22:44), Joe Perches wrote: > > [..] > > > > Sir, is there anything else you want me to improve in this patch > > > > set? > > > I'm not sir, but my preference would be to move as much of the > > > async/thread functionality as possible into a separate file. > > hm, we are talking about some 50-60 lines of code in total (seems > > that the patch set adds more comments than code), but your point > > is interesting. let's say, if there will be more opinions that it > > better land in async_printk.{c,h} files, then I'll take a look on > > it. how does it sound? > > I think printk.c is pretty large, complicated and should > be broken up into several bits. > > I did that once, but it's a real development timing issue  > https://lkml.org/lkml/2012/10/17/41 As much as that may be a useful excercise, I don't think it really belongs in this rather small patch set. Honza -- Jan Kara SUSE Labs, CR