From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH v4 6/6] hwmon: use smp_call_on_cpu() for dell-smm i8k Date: Thu, 21 Apr 2016 15:27:35 +0200 Message-ID: <20160421132735.GR29406@pali> References: <1459833007-11618-1-git-send-email-jgross@suse.com> <1459833007-11618-7-git-send-email-jgross@suse.com> <20160405145414.GB27359@roeck-us.net> <201604052131.52765@pali> <20160421105724.GK29406@pali> <5718D1D4.3040309@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <5718D1D4.3040309@suse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Juergen Gross Cc: x86@kernel.org, jeremy@goop.org, jdelvare@suse.com, peterz@infradead.org, akataria@vmware.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, chrisw@sous-sol.org, mingo@redhat.com, david.vrabel@citrix.com, Douglas_Warzecha@dell.com, hpa@zytor.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, tglx@linutronix.de, Guenter Roeck List-Id: virtualization@lists.linuxfoundation.org T24gVGh1cnNkYXkgMjEgQXByaWwgMjAxNiAxNToxMjo1MiBKdWVyZ2VuIEdyb3NzIHdyb3RlOgo+ IE9uIDIxLzA0LzE2IDEyOjU3LCBQYWxpIFJvaMOhciB3cm90ZToKPiA+IE9uIFR1ZXNkYXkgMDUg QXByaWwgMjAxNiAyMTozMTo1MiBQYWxpIFJvaMOhciB3cm90ZToKPiA+PiBPbiBUdWVzZGF5IDA1 IEFwcmlsIDIwMTYgMTY6NTQ6MTQgR3VlbnRlciBSb2VjayB3cm90ZToKPiA+Pj4gT24gVHVlLCBB cHIgMDUsIDIwMTYgYXQgMDc6MTA6MDdBTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90ZToKPiA+ Pj4+IFVzZSB0aGUgc21wX2NhbGxfb25fY3B1KCkgZnVuY3Rpb24gdG8gY2FsbCBzeXN0ZW0gbWFu YWdlbWVudAo+ID4+Pj4gbW9kZSBvbiBjcHUgMC4KPiA+Pj4+IE1ha2UgY2FsbCBzZWN1cmUgYnkg YWRkaW5nIGdldF9vbmxpbmVfY3B1cygpIHRvIGF2b2lkIGUuZy4gc3VzcGVuZAo+ID4+Pj4gcmVz dW1lIGN5Y2xlcyBpbiBiZXR3ZWVuLgo+ID4+Pj4KPiA+Pj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4KPiA+Pj4+IC0tLQo+ID4+Pj4gVjQ6IGFkZCBjYWxs IHRvIGdldF9vbmxpbmVfY3B1cygpCj4gPj4+Cj4gPj4+IFBhbGksIGFueSBjaGFuY2UgdG8gdGVz dCB0aGlzID8KPiA+Pgo+ID4+IEkgY2FuIHRlc3QgaXQsIGJ1dCBqdXN0IG9uIG1hY2hpbmUgd2hl cmUgKHByb2JhYmx5KSBzbW0gY2FsbHMgY2FuIGJlIAo+ID4+IHNlbmQgZnJvbSBhbnkgY3B1Li4u IE5lZWQgc29tZSB0aW1lIGZvciB0ZXN0aW5nIGFuZCBJIGJlbGlldmUgSSBjYW4gZG8gCj4gPj4g dGhhdCBhdCB0aGUgZW5kIG9mIHRoZSB3ZWVrLgo+ID4gCj4gPiBTb3JyeSBJIGhhZCBhYnNvbHV0 ZWx5IG5vIG1vcmUgZnJlZSB0aW1lIGxhc3Qgd2Vla2VuZCA6LSggQW5kIHNhbWUKPiA+IHByZWRp Y3Rpb24gaXMgZm9yIHRoaXMgd2Vla2VuZCBhbmQgYWxzbyBuZXh0IG9uZS4uLgo+IAo+IFBhbGks IEkndmUgZ290IGEgRGVsbCBsYXB0b3AgKExhdGl0dWRlIEU2NDQwKSBoZXJlLiBXb3VsZCB0aGlz IGRldmljZSBiZQo+IG9rYXkgZm9yIGEgdGVzdD8KCkhpIQoKUHJvcGVyIHJlZ3Jlc3Npb24gdGVz dCBzaG91bGQgY2hlY2sgaWYgdGhpcyBwYXRjaCBkb2VzIG5vdCBicmVhayBhbnkKZnVuY3Rpb24g b3IgZHJpdmVycyBkZXBlbmRlbnQgb24gZGNkYmFzLmtvLiBBbmQgc2hvdWxkIGJlIGRvbmUgb24g Ym90aApub3RlYm9vayBkZXZpY2VzOiB3aGljaCBuZWVkcyB0byBpc3N1ZSB0aGF0IHNtbSBjYWxs IG9uIGNwdSAwIGFuZCBhbHNvCm9uIHdoaWNoIGl0IGlzIG5vdCBuZWVkZWQuCgpTb21lIG5vdGVi b29rcyB3aGljaCBuZWVkcyBzbW0gY2FsbCB0byBpc3N1ZWQgZnJvbSBjcHUgMCBjYW4gYmUgZm91 bmQgaW4KZ2l0IGNvbW1pdCBtZXNzYWdlcyBvZiBpOGssIGRlbGwtbGFwdG9wIG9yIGRjZGJhcyBr ZXJuZWwgZHJpdmVycy4KCj4gV2hhdCB3b3VsZCB5b3UgZG8gZm9yIHRlc3Rpbmc/IEluIGNhc2Ug eW91IGNhbiBnaXZlIG1lCj4gc29tZSBoaW50cyBob3cgdG8gZG8gYSBzZW5zaWJsZSB0ZXN0IEkn ZCBkbyBpdC4KClRlc3QgZS5nLiBkZWxsLWxhcHRvcC5rbyBkcml2ZXIuIEl0IHByb3ZpZGVzIC9z eXMgaW50ZXJmYWNlIGZvciBjaGFuZ2luZwprZXlib2FyZCBiYWNrbGlnaHQgb3IgY2hhbmdpbmcg cmZraWxsIHN3aXRjaGVzIChibHVldG9vdGggd2lmaSkuCgpBbHNvIHRlc3QgdG9vbHMgZnJvbSBs aWJzbWJpb3MgKHVzZXJzcGFjZSkgcGFja2FnZS4KClRoZXJlIG11c3QgYmUgbm8gZGlmZmVyZW5j ZSBpbiBvdXRwdXQvZnVuY3Rpb25hbGl0eSB3aXRoIG9yIHdpdGhvdXQgeW91cgpwYXRjaGVzLgoK PiBJJ3ZlIHZlcmlmaWVkIGJ5IGFkZGluZyBhIHByaW50aygpIHRvIHNtcF9jYWxsX29uX2NwdSgp IHRoYXQgYXQgbGVhc3QKPiBvbmUgb2YgdGhlIG1vZGlmaWVkIGRyaXZlcnMgaGFzIGJlZW4gdXNl ZCBkdXJpbmcgc3lzdGVtIGJvb3QuCgpBbHNvIHlvdSBjYW4gcGF0Y2ggaThrL2RjZGJhcyBzbW0g ZnVuY3Rpb24gdG8gcHJpbnQgY3B1IG51bWJlciBvbiB3aGljaAppcyBjb2RlIHJ1bm5pbmcgKHRv IHZlcmlmeSB0aGF0IGl0IHdhcyByZWFsbHkgY2FsbGVkIG9uIGNwdSAwIGFzCm5lZWRlZCkuCgot LSAKUGFsaSBSb2jDoXIKcGFsaS5yb2hhckBnbWFpbC5jb20KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZp cnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGlu dXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbcDUN1l (ORCPT ); Thu, 21 Apr 2016 09:27:41 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37068 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbcDUN1k (ORCPT ); Thu, 21 Apr 2016 09:27:40 -0400 Date: Thu, 21 Apr 2016 15:27:35 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Juergen Gross Cc: Guenter Roeck , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, mingo@redhat.com, peterz@infradead.org, Douglas_Warzecha@dell.com, jdelvare@suse.com, tglx@linutronix.de, hpa@zytor.com, jeremy@goop.org, chrisw@sous-sol.org, akataria@vmware.com, rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org, x86@kernel.org Subject: Re: [PATCH v4 6/6] hwmon: use smp_call_on_cpu() for dell-smm i8k Message-ID: <20160421132735.GR29406@pali> References: <1459833007-11618-1-git-send-email-jgross@suse.com> <1459833007-11618-7-git-send-email-jgross@suse.com> <20160405145414.GB27359@roeck-us.net> <201604052131.52765@pali> <20160421105724.GK29406@pali> <5718D1D4.3040309@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5718D1D4.3040309@suse.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 21 April 2016 15:12:52 Juergen Gross wrote: > On 21/04/16 12:57, Pali Rohár wrote: > > On Tuesday 05 April 2016 21:31:52 Pali Rohár wrote: > >> On Tuesday 05 April 2016 16:54:14 Guenter Roeck wrote: > >>> On Tue, Apr 05, 2016 at 07:10:07AM +0200, Juergen Gross wrote: > >>>> Use the smp_call_on_cpu() function to call system management > >>>> mode on cpu 0. > >>>> Make call secure by adding get_online_cpus() to avoid e.g. suspend > >>>> resume cycles in between. > >>>> > >>>> Signed-off-by: Juergen Gross > >>>> --- > >>>> V4: add call to get_online_cpus() > >>> > >>> Pali, any chance to test this ? > >> > >> I can test it, but just on machine where (probably) smm calls can be > >> send from any cpu... Need some time for testing and I believe I can do > >> that at the end of the week. > > > > Sorry I had absolutely no more free time last weekend :-( And same > > prediction is for this weekend and also next one... > > Pali, I've got a Dell laptop (Latitude E6440) here. Would this device be > okay for a test? Hi! Proper regression test should check if this patch does not break any function or drivers dependent on dcdbas.ko. And should be done on both notebook devices: which needs to issue that smm call on cpu 0 and also on which it is not needed. Some notebooks which needs smm call to issued from cpu 0 can be found in git commit messages of i8k, dell-laptop or dcdbas kernel drivers. > What would you do for testing? In case you can give me > some hints how to do a sensible test I'd do it. Test e.g. dell-laptop.ko driver. It provides /sys interface for changing keyboard backlight or changing rfkill switches (bluetooth wifi). Also test tools from libsmbios (userspace) package. There must be no difference in output/functionality with or without your patches. > I've verified by adding a printk() to smp_call_on_cpu() that at least > one of the modified drivers has been used during system boot. Also you can patch i8k/dcdbas smm function to print cpu number on which is code running (to verify that it was really called on cpu 0 as needed). -- Pali Rohár pali.rohar@gmail.com