From: Stephen Hemminger <shemming@brocade.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"phil@nwl.cc" <phil@nwl.cc>
Subject: Re: [net-next PATCH iproute2 v2 1/1] tc: introduce IFE action
Date: Thu, 21 Apr 2016 14:36:57 -0700 [thread overview]
Message-ID: <20160421143657.51ba9fdd@xeon-e3> (raw)
In-Reply-To: <e6070b054b0748f48991187bb4ccfccd@HQ1WP-EXMB11.corp.brocade.com>
On Thu, 21 Apr 2016 21:27:39 +0000
Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> > The code has also gotten deeply intended creating lots of lines that are too long.
> >
>
> Is this you or the script saying the above? How is the conclusion that
> we have deep indentation come about?
> I checked there are some code lines that are > 80 characters because
> it doesnt make sense to break them down.
I use checkpatch from kernel source to check iproute code now.
next prev parent reply other threads:[~2016-04-21 21:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 12:04 [net-next PATCH iproute2 v2 0/1] tc ife action Jamal Hadi Salim
2016-03-09 12:04 ` [net-next PATCH iproute2 v2 1/1] tc: introduce IFE action Jamal Hadi Salim
2016-03-09 13:12 ` Phil Sutter
2016-03-10 12:42 ` Jamal Hadi Salim
2016-03-10 13:12 ` Phil Sutter
2016-03-14 6:26 ` Stephen Hemminger
2016-04-21 21:27 ` Jamal Hadi Salim
[not found] ` <e6070b054b0748f48991187bb4ccfccd@HQ1WP-EXMB11.corp.brocade.com>
2016-04-21 21:36 ` Stephen Hemminger [this message]
2016-04-21 21:41 ` Jamal Hadi Salim
2016-04-21 22:09 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421143657.51ba9fdd@xeon-e3 \
--to=shemming@brocade.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.