From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au,
smueller@chronox.de, mmarek@suse.com, arnd@arndb.de,
andrew.zaborowski@intel.com
Subject: Re: [PATCH] lib/mpi: Fix kernel unaligned acces in mpi_write_to_sgl
Date: Thu, 21 Apr 2016 13:44:42 -0400 [thread overview]
Message-ID: <20160421174442.GD25698@oracle.com> (raw)
In-Reply-To: <57190C88.8000608@intel.com>
On (04/21/16 10:23), Tadeusz Struk wrote:
>
> What if the mpi_limb_t will happen to be 64 bit?
> Thanks,
When I checked this with cscope, I found
typedef unsigned long int mpi_limb_t;
thus I used the *32 functions.
But you obviously know better, since you wrote this code (and bug).
If you anticipate that mpi_limb_t in some environment today,
I can check for sizeof(mpi_limb_t), and predicate it to
use the *32 or *64 functions based on the result. Do you think that
is necessary?
Regards,
--Sowmini
prev parent reply other threads:[~2016-04-21 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 11:07 [PATCH] lib/mpi: Fix kernel unaligned acces in mpi_write_to_sgl Sowmini Varadhan
2016-04-21 17:23 ` Tadeusz Struk
2016-04-21 17:44 ` Sowmini Varadhan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421174442.GD25698@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=andrew.zaborowski@intel.com \
--cc=arnd@arndb.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=smueller@chronox.de \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.