All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Balbir Singh <bsingharora@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: perfbook patch
Date: Thu, 21 Apr 2016 15:06:21 -0700	[thread overview]
Message-ID: <20160421220621.GH3879@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAKTCnzmSeS85fmCfZKhGbiDNt9gdyOVxWQcdAahT8R3OR+ETpg@mail.gmail.com>

On Fri, Apr 22, 2016 at 07:52:19AM +1000, Balbir Singh wrote:
> On Fri, Apr 22, 2016 at 2:18 AM, Paul E. McKenney
> <paulmck@linux.vnet.ibm.com> wrote:
> > On Thu, Apr 21, 2016 at 05:40:30PM +1000, Balbir Singh wrote:
> >> Hey, Paul
> >>
> >> perfbook failed to build on Fedora 23 due to a texlive issue. I am not sure if other users are facing it. In any case I came up with a patch -- update FAQ.txt with an answer. I was not sure if it is worth posting to perfbook mailing list
> >>
> >> I'm attaching it - FYI. I hope its useful
> >>
> >> Balbir
> >
> > Hello, Balbir, and thank you!
> >
> > I tried it on Ubuntu 14.04, and it works just fine there.  So are you
> > OK with the following hijacking of your original patch?
> >
> >                                                         Thanx, Paul
> >
> > ------------------------------------------------------------------------
> >
> > commit 8c4c3c54d4d4246f6b13a914dda9c9ac42bf0c2e
> > Author: Balbir Singh <bsingharora@gmail.com>
> > Date:   Thu Apr 21 09:16:44 2016 -0700
> >
> >     Fix build error on Fedora 23 with texlive
> >
> >     The listings package is broken. The fix suggested is taken from
> >     http://osdir.com/ml/general/2014-06/msg50467.html
> >
> >     Signed-off-by: Balbir Singh <bsingharora@gmail.com>
> >     Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >
> > diff --git a/perfbook.tex b/perfbook.tex
> > index ac46e74f6b6f..d607f66b428f 100644
> > --- a/perfbook.tex
> > +++ b/perfbook.tex
> > @@ -35,6 +35,18 @@
> >    literate={\_}{}{0\discretionary{\_}{}{\_}}%
> >  }
> >  %%HTMLNOSKIP
> > +\makeatletter
> > +\renewcommand\lstinline[1][]{%
> > +\leavevmode\bgroup % \hbox\bgroup --> \bgroup
> > +\def\lst@boxpos{b}%
> > +\lsthk@PreSet\lstset{flexiblecolumns,#1}%
> > +\lsthk@TextStyle
> > +\ifnum\iffalse{\fi`}=\z@\fi
> > +\@ifnextchar\bgroup{%
> > +\ifnum`{=\z@}\fi%
> > +\afterassignment\lst@InlineG \let\@let@token}{%
> > +\ifnum`{=\z@}\fi\lstinline@}}
> > +\makeatother
> >  \newcommand{\co}[1]{\lstinline[breaklines=yes,breakatwhitespace=yes]{#1}}
> >
> >  \title{Is Parallel Programming Hard, And, If So, What Can You Do About It?}
> 
> Absolutely!

Very good!  I added some comments saying what the block of commands was
for, and pushed it out.

							Thanx, Paul


      reply	other threads:[~2016-04-21 22:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <571883EE.4080103@gmail.com>
2016-04-21 16:18 ` perfbook patch Paul E. McKenney
2016-04-21 21:52   ` Balbir Singh
2016-04-21 22:06     ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160421220621.GH3879@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=bsingharora@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.