From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Fri, 22 Apr 2016 08:24:15 +0000 Subject: Re: [PATCH 2/8] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*() Message-Id: <20160422082415.GG2510@phenom.ffwll.local> List-Id: References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-3-git-send-email-noralf@tronnes.org> <20160420174241.GP2510@phenom.ffwll.local> <5717C742.7080807@tronnes.org> <20160421072847.GW2510@phenom.ffwll.local> <57191988.3020904@tronnes.org> In-Reply-To: <57191988.3020904@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: linux-fbdev@vger.kernel.org, tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org On Thu, Apr 21, 2016 at 08:18:48PM +0200, Noralf Tr=F8nnes wrote: >=20 > Den 21.04.2016 09:28, skrev Daniel Vetter: > >On Wed, Apr 20, 2016 at 08:15:30PM +0200, Noralf Tr=F8nnes wrote: > >>Den 20.04.2016 19:42, skrev Daniel Vetter: > >>>On Wed, Apr 20, 2016 at 05:25:23PM +0200, Noralf Tr=F8nnes wrote: > >>>>Now that drm_fb_helper gets deferred io support, the > >>>>drm_fb_helper_sys_{fillrect,copyarea,imageblit} functions will schedu= le > >>>>the worker that calls the deferred_io callback. This will break this > >>>>driver so use the sys_{fillrect,copyarea,imageblit} functions directl= y. > >>>> > >>>>Signed-off-by: Noralf Tr=F8nnes > >>>I think this intermediately breaks the build, if you disable fbdev > >>>support. That's now supported in the fbdev helpers core generically ac= ross > >>>all drivers. > >>> > >>>Not sure how to best fix this up, since the only way would be to squash > >>>these patches, plus generic deferred io plus the conversion patches for > >>>udl/qxl all into one. Tricky. > >>Yes you're right, I missed that. > >>How about this: > >>#ifdef CONFIG_FB > >> sys_fillrect(info, rect); > >>#endif > >> > >>The later patch will then remove this ugliness... > >Yeah I think we have to bite the bullet and take this temporary ugliness > >:( >=20 > Turns out the #ifdef isn't necessary since FB is always selected. >=20 > Both udl and qxl have this: > select DRM_KMS_HELPER > select DRM_KMS_FB_HELPER >=20 > And then we have: >=20 > config DRM_KMS_HELPER > tristate > depends on DRM >=20 > config DRM_KMS_FB_HELPER > bool > depends on DRM_KMS_HELPER > select FB > ... > select FB_SYS_FILLRECT > select FB_SYS_COPYAREA > select FB_SYS_IMAGEBLIT Hm ... the thing that actually builds fbdev emulation is DRM_FBDEV_EMULATION, and you can disable that. Otoh the select FB stuff seems to be at the wrong level and probably should be moved. But indeed I tried doing this and it's an impossible config. I guess I need to type a patch to ditch all these selects from drivers ;-) -Daniel --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/8] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*() Date: Fri, 22 Apr 2016 10:24:15 +0200 Message-ID: <20160422082415.GG2510@phenom.ffwll.local> References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-3-git-send-email-noralf@tronnes.org> <20160420174241.GP2510@phenom.ffwll.local> <5717C742.7080807@tronnes.org> <20160421072847.GW2510@phenom.ffwll.local> <57191988.3020904@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 680C16E218 for ; Fri, 22 Apr 2016 08:24:20 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id r12so2269849wme.0 for ; Fri, 22 Apr 2016 01:24:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: <57191988.3020904@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: linux-fbdev@vger.kernel.org, tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBBcHIgMjEsIDIwMTYgYXQgMDg6MTg6NDhQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IAo+IERlbiAyMS4wNC4yMDE2IDA5OjI4LCBza3JldiBEYW5pZWwgVmV0dGVyOgo+ ID5PbiBXZWQsIEFwciAyMCwgMjAxNiBhdCAwODoxNTozMFBNICswMjAwLCBOb3JhbGYgVHLDuG5u ZXMgd3JvdGU6Cj4gPj5EZW4gMjAuMDQuMjAxNiAxOTo0Miwgc2tyZXYgRGFuaWVsIFZldHRlcjoK PiA+Pj5PbiBXZWQsIEFwciAyMCwgMjAxNiBhdCAwNToyNToyM1BNICswMjAwLCBOb3JhbGYgVHLD uG5uZXMgd3JvdGU6Cj4gPj4+Pk5vdyB0aGF0IGRybV9mYl9oZWxwZXIgZ2V0cyBkZWZlcnJlZCBp byBzdXBwb3J0LCB0aGUKPiA+Pj4+ZHJtX2ZiX2hlbHBlcl9zeXNfe2ZpbGxyZWN0LGNvcHlhcmVh LGltYWdlYmxpdH0gZnVuY3Rpb25zIHdpbGwgc2NoZWR1bGUKPiA+Pj4+dGhlIHdvcmtlciB0aGF0 IGNhbGxzIHRoZSBkZWZlcnJlZF9pbyBjYWxsYmFjay4gVGhpcyB3aWxsIGJyZWFrIHRoaXMKPiA+ Pj4+ZHJpdmVyIHNvIHVzZSB0aGUgc3lzX3tmaWxscmVjdCxjb3B5YXJlYSxpbWFnZWJsaXR9IGZ1 bmN0aW9ucyBkaXJlY3RseS4KPiA+Pj4+Cj4gPj4+PlNpZ25lZC1vZmYtYnk6IE5vcmFsZiBUcsO4 bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+ID4+PkkgdGhpbmsgdGhpcyBpbnRlcm1lZGlhdGVs eSBicmVha3MgdGhlIGJ1aWxkLCBpZiB5b3UgZGlzYWJsZSBmYmRldgo+ID4+PnN1cHBvcnQuIFRo YXQncyBub3cgc3VwcG9ydGVkIGluIHRoZSBmYmRldiBoZWxwZXJzIGNvcmUgZ2VuZXJpY2FsbHkg YWNyb3NzCj4gPj4+YWxsIGRyaXZlcnMuCj4gPj4+Cj4gPj4+Tm90IHN1cmUgaG93IHRvIGJlc3Qg Zml4IHRoaXMgdXAsIHNpbmNlIHRoZSBvbmx5IHdheSB3b3VsZCBiZSB0byBzcXVhc2gKPiA+Pj50 aGVzZSBwYXRjaGVzLCBwbHVzIGdlbmVyaWMgZGVmZXJyZWQgaW8gcGx1cyB0aGUgY29udmVyc2lv biBwYXRjaGVzIGZvcgo+ID4+PnVkbC9xeGwgYWxsIGludG8gb25lLiBUcmlja3kuCj4gPj5ZZXMg eW91J3JlIHJpZ2h0LCBJIG1pc3NlZCB0aGF0Lgo+ID4+SG93IGFib3V0IHRoaXM6Cj4gPj4jaWZk ZWYgQ09ORklHX0ZCCj4gPj4gICAgICAgICBzeXNfZmlsbHJlY3QoaW5mbywgcmVjdCk7Cj4gPj4j ZW5kaWYKPiA+Pgo+ID4+VGhlIGxhdGVyIHBhdGNoIHdpbGwgdGhlbiByZW1vdmUgdGhpcyB1Z2xp bmVzcy4uLgo+ID5ZZWFoIEkgdGhpbmsgd2UgaGF2ZSB0byBiaXRlIHRoZSBidWxsZXQgYW5kIHRh a2UgdGhpcyB0ZW1wb3JhcnkgdWdsaW5lc3MKPiA+OigKPiAKPiBUdXJucyBvdXQgdGhlICNpZmRl ZiBpc24ndCBuZWNlc3Nhcnkgc2luY2UgRkIgaXMgYWx3YXlzIHNlbGVjdGVkLgo+IAo+IEJvdGgg dWRsIGFuZCBxeGwgaGF2ZSB0aGlzOgo+ICAgICAgICAgc2VsZWN0IERSTV9LTVNfSEVMUEVSCj4g ICAgICAgICBzZWxlY3QgRFJNX0tNU19GQl9IRUxQRVIKPiAKPiBBbmQgdGhlbiB3ZSBoYXZlOgo+ IAo+IGNvbmZpZyBEUk1fS01TX0hFTFBFUgo+ICAgICAgICAgdHJpc3RhdGUKPiAgICAgICAgIGRl cGVuZHMgb24gRFJNCj4gCj4gY29uZmlnIERSTV9LTVNfRkJfSEVMUEVSCj4gICAgICAgICBib29s Cj4gICAgICAgICBkZXBlbmRzIG9uIERSTV9LTVNfSEVMUEVSCj4gICAgICAgICBzZWxlY3QgRkIK PiAgICAgICAgIC4uLgo+ICAgICAgICAgc2VsZWN0IEZCX1NZU19GSUxMUkVDVAo+ICAgICAgICAg c2VsZWN0IEZCX1NZU19DT1BZQVJFQQo+ICAgICAgICAgc2VsZWN0IEZCX1NZU19JTUFHRUJMSVQK CkhtIC4uLiB0aGUgdGhpbmcgdGhhdCBhY3R1YWxseSBidWlsZHMgZmJkZXYgZW11bGF0aW9uIGlz CkRSTV9GQkRFVl9FTVVMQVRJT04sIGFuZCB5b3UgY2FuIGRpc2FibGUgdGhhdC4gT3RvaCB0aGUg c2VsZWN0IEZCIHN0dWZmCnNlZW1zIHRvIGJlIGF0IHRoZSB3cm9uZyBsZXZlbCBhbmQgcHJvYmFi bHkgc2hvdWxkIGJlIG1vdmVkLgoKQnV0IGluZGVlZCBJIHRyaWVkIGRvaW5nIHRoaXMgYW5kIGl0 J3MgYW4gaW1wb3NzaWJsZSBjb25maWcuIEkgZ3Vlc3MgSQpuZWVkIHRvIHR5cGUgYSBwYXRjaCB0 byBkaXRjaCBhbGwgdGhlc2Ugc2VsZWN0cyBmcm9tIGRyaXZlcnMgOy0pCi1EYW5pZWwKLS0gCkRh bmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9i bG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753954AbcDVIYX (ORCPT ); Fri, 22 Apr 2016 04:24:23 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36475 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753551AbcDVIYU (ORCPT ); Fri, 22 Apr 2016 04:24:20 -0400 Date: Fri, 22 Apr 2016 10:24:15 +0200 From: Daniel Vetter To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*() Message-ID: <20160422082415.GG2510@phenom.ffwll.local> Mail-Followup-To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org References: <1461165929-11344-1-git-send-email-noralf@tronnes.org> <1461165929-11344-3-git-send-email-noralf@tronnes.org> <20160420174241.GP2510@phenom.ffwll.local> <5717C742.7080807@tronnes.org> <20160421072847.GW2510@phenom.ffwll.local> <57191988.3020904@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <57191988.3020904@tronnes.org> X-Operating-System: Linux phenom 4.4.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2016 at 08:18:48PM +0200, Noralf Trønnes wrote: > > Den 21.04.2016 09:28, skrev Daniel Vetter: > >On Wed, Apr 20, 2016 at 08:15:30PM +0200, Noralf Trønnes wrote: > >>Den 20.04.2016 19:42, skrev Daniel Vetter: > >>>On Wed, Apr 20, 2016 at 05:25:23PM +0200, Noralf Trønnes wrote: > >>>>Now that drm_fb_helper gets deferred io support, the > >>>>drm_fb_helper_sys_{fillrect,copyarea,imageblit} functions will schedule > >>>>the worker that calls the deferred_io callback. This will break this > >>>>driver so use the sys_{fillrect,copyarea,imageblit} functions directly. > >>>> > >>>>Signed-off-by: Noralf Trønnes > >>>I think this intermediately breaks the build, if you disable fbdev > >>>support. That's now supported in the fbdev helpers core generically across > >>>all drivers. > >>> > >>>Not sure how to best fix this up, since the only way would be to squash > >>>these patches, plus generic deferred io plus the conversion patches for > >>>udl/qxl all into one. Tricky. > >>Yes you're right, I missed that. > >>How about this: > >>#ifdef CONFIG_FB > >> sys_fillrect(info, rect); > >>#endif > >> > >>The later patch will then remove this ugliness... > >Yeah I think we have to bite the bullet and take this temporary ugliness > >:( > > Turns out the #ifdef isn't necessary since FB is always selected. > > Both udl and qxl have this: > select DRM_KMS_HELPER > select DRM_KMS_FB_HELPER > > And then we have: > > config DRM_KMS_HELPER > tristate > depends on DRM > > config DRM_KMS_FB_HELPER > bool > depends on DRM_KMS_HELPER > select FB > ... > select FB_SYS_FILLRECT > select FB_SYS_COPYAREA > select FB_SYS_IMAGEBLIT Hm ... the thing that actually builds fbdev emulation is DRM_FBDEV_EMULATION, and you can disable that. Otoh the select FB stuff seems to be at the wrong level and probably should be moved. But indeed I tried doing this and it's an impossible config. I guess I need to type a patch to ditch all these selects from drivers ;-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch