From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 22 Apr 2016 17:48:26 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:8059 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27025160AbcDVPsYoSLxy (ORCPT ); Fri, 22 Apr 2016 17:48:24 +0200 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Websense Email with ESMTPS id 5B38227A93B4; Fri, 22 Apr 2016 16:48:15 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (TLS) id 14.3.266.1; Fri, 22 Apr 2016 16:48:18 +0100 Received: from mredfearn-linux (192.168.154.116) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.266.1; Fri, 22 Apr 2016 16:48:18 +0100 Date: Fri, 22 Apr 2016 16:48:17 +0100 From: Matt Redfearn To: Thomas Gleixner CC: , , , , , , , Qais Yousef Subject: Re: [PATCH 2/2] genirq: Add error code reporting to irq_{reserve,destroy}_ipi Message-ID: <20160422154816.GA10886@mredfearn-linux> References: <1461338809-10590-1-git-send-email-matt.redfearn@imgtec.com> <1461338809-10590-2-git-send-email-matt.redfearn@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [192.168.154.116] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 53208 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: matt.redfearn@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Fri, Apr 22, 2016 at 05:35:46PM +0200, Thomas Gleixner wrote: > On Fri, 22 Apr 2016, Matt Redfearn wrote: > > > Make these functions return appropriate error codes when something goes > > wrong. > > And the reason for this change is? Hi Thomas, Mainly for irq_destroy_ipi, where the first patch in the set makes it possible for the request to fail. But in general with both of these functions it is possible for them to silently fail without giving the caller any idication if inapropriate arguments are passed. Thanks, Matt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:8059 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27025160AbcDVPsYoSLxy (ORCPT ); Fri, 22 Apr 2016 17:48:24 +0200 Date: Fri, 22 Apr 2016 16:48:17 +0100 From: Matt Redfearn Subject: Re: [PATCH 2/2] genirq: Add error code reporting to irq_{reserve,destroy}_ipi Message-ID: <20160422154816.GA10886@mredfearn-linux> References: <1461338809-10590-1-git-send-email-matt.redfearn@imgtec.com> <1461338809-10590-2-git-send-email-matt.redfearn@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Thomas Gleixner Cc: lisa.parratt@imgtec.com, jason@lakedaemon.net, ralf@linux-mips.org, linux-kernel@vger.kernel.org, jiang.liu@linux.intel.com, marc.zyngier@arm.com, linux-mips@linux-mips.org, Qais Yousef Message-ID: <20160422154817.zNNY8phWAj4bp58lhmtYmWRUcekEv349prdMfAGllr8@z> On Fri, Apr 22, 2016 at 05:35:46PM +0200, Thomas Gleixner wrote: > On Fri, 22 Apr 2016, Matt Redfearn wrote: > > > Make these functions return appropriate error codes when something goes > > wrong. > > And the reason for this change is? Hi Thomas, Mainly for irq_destroy_ipi, where the first patch in the set makes it possible for the request to fail. But in general with both of these functions it is possible for them to silently fail without giving the caller any idication if inapropriate arguments are passed. Thanks, Matt