From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3] drm/i915: Fake HDMI live status Date: Fri, 22 Apr 2016 20:34:43 +0300 Message-ID: <20160422173443.GV4329@intel.com> References: <1461237606-16491-1-git-send-email-shashank.sharma@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id CB7696EF3F for ; Fri, 22 Apr 2016 17:34:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1461237606-16491-1-git-send-email-shashank.sharma@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shashank Sharma Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, daniel.vetter@intel.com, joseph.salisbury@canonical.com List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMjEsIDIwMTYgYXQgMDQ6NDg6MzJQTSArMDUzMCwgU2hhc2hhbmsgU2hhcm1h IHdyb3RlOgo+IFRoaXMgcGF0Y2ggZG9lcyB0aGUgZm9sbG93aW5nOgo+IC0gRmFrZXMgbGl2ZSBz dGF0dXMgb2YgSERNSSBhcyBjb25uZWN0ZWQgKGV2ZW4gaWYgdGhhdCdzIG5vdCkuCj4gICBXaGls ZSB0ZXN0aW5nIGNlcnRhaW4gKG1vbml0b3IgKyBjYWJsZSkgY29tYmluYXRpb25zIHdpdGgKPiAg IHZhcmlvdXMgaW50ZWwgIHBsYXRmb3JtcywgaXQgc2VlbXMgdGhhdCBsaXZlIHN0YXR1cyByZWdp c3Rlcgo+ICAgZG9lc24ndCB3b3JrIHJlbGlhYmx5IG9uIHNvbWUgb2xkZXIgZGV2aWNlcy4gU28g bGltaXQgdGhlCj4gICBsaXZlX3N0YXR1cyBjaGVjayBmb3IgSERNSSBkZXRlY3Rpb24sIG9ubHkg Zm9yIHBsYXRmb3Jtcwo+ICAgZnJvbSBnZW43IG9ud2FyZHMuCj4gCj4gRml4ZXM6IDIzN2VkODZj NjkzZCAoImRybS9pOTE1OiBDaGVjayBsaXZlIHN0YXR1cyBiZWZvcmUgcmVhZGluZyBlZGlkIikK PiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZyAjIHY0LjQKPiAKPiBWMjogcmVzdHJpY3QgZmFr aW5nIGxpdmVfc3RhdHVzIHRvIGNlcnRhaW4gcGxhdGZvcm1zCj4gVjM6IChWaWxsZSkKPiAgICAt IGtlZXAgdGhlIGRlYnVnIG1lc3NhZ2UgZm9yICFsaXZlX3N0YXR1cyBjYXNlCj4gICAgLSBmaXgg aW5kZW50YXRpb24gb2YgY29tbWVudAo+ICAgIC0gcmVtb3ZlICJ3YXJuaW5nIiBmcm9tIHRoZSBk ZWJ1ZyBtZXNzYWdlCj4gCj4gICAgIChKYW5pKQo+ICAgIC0gQ2hhbmdlIGZvcm1hdCBvZiBmaXgg ZGV0YWlscyBpbiB0aGUgY29tbWl0IG1lc3NhZ2UKPiAKPiBTdWdnZXN0ZWQtYnk6IFZpbGxlIFN5 cmphbGEgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFNo YXNoYW5rIFNoYXJtYSA8c2hhc2hhbmsuc2hhcm1hQGludGVsLmNvbT4KClB1c2hlZCB0byBkaW5x LiBUaGFua3MgZm9yIHRoZSBwYXRjaC4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2hkbWkuYyB8IDEyICsrKysrKysrKystLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfaGRtaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jCj4g aW5kZXggYjE5OWVkZS4uMmNkYWI3MyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9oZG1pLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMK PiBAQCAtMTQxMiw4ICsxNDEyLDE2IEBAIGludGVsX2hkbWlfZGV0ZWN0KHN0cnVjdCBkcm1fY29u bmVjdG9yICpjb25uZWN0b3IsIGJvb2wgZm9yY2UpCj4gIAkJCQloZG1pX3RvX2RpZ19wb3J0KGlu dGVsX2hkbWkpKTsKPiAgCX0KPiAgCj4gLQlpZiAoIWxpdmVfc3RhdHVzKQo+IC0JCURSTV9ERUJV R19LTVMoIkxpdmUgc3RhdHVzIG5vdCB1cCEiKTsKPiArCWlmICghbGl2ZV9zdGF0dXMpIHsKPiAr CQlEUk1fREVCVUdfS01TKCJIRE1JIGxpdmUgc3RhdHVzIGRvd25cbiIpOwo+ICsJCS8qCj4gKwkJ ICogTGl2ZSBzdGF0dXMgcmVnaXN0ZXIgaXMgbm90IHJlbGlhYmxlIG9uIGFsbCBpbnRlbCBwbGF0 Zm9ybXMuCj4gKwkJICogU28gY29uc2lkZXIgbGl2ZV9zdGF0dXMgb25seSBmb3IgY2VydGFpbiBw bGF0Zm9ybXMsIGZvcgo+ICsJCSAqIG90aGVycywgcmVhZCBFRElEIHRvIGRldGVybWluZSBwcmVz ZW5jZSBvZiBzaW5rLgo+ICsJCSAqLwo+ICsJCWlmIChJTlRFTF9JTkZPKGRldl9wcml2KS0+Z2Vu IDwgNyB8fCBJU19JVllCUklER0UoZGV2X3ByaXYpKQo+ICsJCQlsaXZlX3N0YXR1cyA9IHRydWU7 Cj4gKwl9Cj4gIAo+ICAJaW50ZWxfaGRtaV91bnNldF9lZGlkKGNvbm5lY3Rvcik7Cj4gIAo+IC0t IAo+IDEuOS4xCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:19746 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754524AbcDVRet (ORCPT ); Fri, 22 Apr 2016 13:34:49 -0400 Date: Fri, 22 Apr 2016 20:34:43 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Shashank Sharma Cc: jani.nikula@linux.intel.com, intel-gfx@lists.freedesktop.org, joseph.salisbury@canonical.com, sonika.jindal@intel.com, daniel.vetter@intel.com, stable@vger.kernel.org Subject: Re: [PATCH v3] drm/i915: Fake HDMI live status Message-ID: <20160422173443.GV4329@intel.com> References: <1461237606-16491-1-git-send-email-shashank.sharma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1461237606-16491-1-git-send-email-shashank.sharma@intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Apr 21, 2016 at 04:48:32PM +0530, Shashank Sharma wrote: > This patch does the following: > - Fakes live status of HDMI as connected (even if that's not). > While testing certain (monitor + cable) combinations with > various intel platforms, it seems that live status register > doesn't work reliably on some older devices. So limit the > live_status check for HDMI detection, only for platforms > from gen7 onwards. > > Fixes: 237ed86c693d ("drm/i915: Check live status before reading edid") > Cc: stable@vger.kernel.org # v4.4 > > V2: restrict faking live_status to certain platforms > V3: (Ville) > - keep the debug message for !live_status case > - fix indentation of comment > - remove "warning" from the debug message > > (Jani) > - Change format of fix details in the commit message > > Suggested-by: Ville Syrjala > Signed-off-by: Shashank Sharma Pushed to dinq. Thanks for the patch. > --- > drivers/gpu/drm/i915/intel_hdmi.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c > index b199ede..2cdab73 100644 > --- a/drivers/gpu/drm/i915/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > @@ -1412,8 +1412,16 @@ intel_hdmi_detect(struct drm_connector *connector, bool force) > hdmi_to_dig_port(intel_hdmi)); > } > > - if (!live_status) > - DRM_DEBUG_KMS("Live status not up!"); > + if (!live_status) { > + DRM_DEBUG_KMS("HDMI live status down\n"); > + /* > + * Live status register is not reliable on all intel platforms. > + * So consider live_status only for certain platforms, for > + * others, read EDID to determine presence of sink. > + */ > + if (INTEL_INFO(dev_priv)->gen < 7 || IS_IVYBRIDGE(dev_priv)) > + live_status = true; > + } > > intel_hdmi_unset_edid(connector); > > -- > 1.9.1 -- Ville Syrj�l� Intel OTC