From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id k143si186610wmg.1.2016.04.22.16.31.55 for ; Fri, 22 Apr 2016 16:31:55 -0700 (PDT) Date: Sat, 23 Apr 2016 01:31:44 +0200 From: Alexandre Belloni To: =?iso-8859-1?Q?Myl=E8ne?= Josserand Cc: rtc-linux@googlegroups.com, Alessandro Zummo , linux-kernel@vger.kernel.org Subject: [rtc-linux] Re: [PATCH 4/6] rtc: rv3029: Removes some checks and warnings Message-ID: <20160422233144.GG17051@piout.net> References: <20160422232946.GF17051@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <20160422232946.GF17051@piout.net> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 23/04/2016 at 01:29:46 +0200, Alexandre Belloni wrote : > Hi, >=20 > On 21/04/2016 at 20:24:17 +0200, Myl=C4=8Dne Josserand wrote : > > @@ -829,8 +829,6 @@ static void rv3029_unregister_driver(void) > > =20 > > static int rv3049_probe(struct spi_device *spi) > > { > > - int res; > > - unsigned int tmp; >=20 > Well, you just introduced those variables in the previous patch. >=20 And I forgot to add that you still have a few checkpatch warnings to remove while at it: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #129: FILE: drivers/rtc/rtc-rv3029c2.c:129: + unsigned len) WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #141: FILE: drivers/rtc/rtc-rv3029c2.c:141: + unsigned len) --=20 Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --=20 --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753181AbcDVXb6 (ORCPT ); Fri, 22 Apr 2016 19:31:58 -0400 Received: from down.free-electrons.com ([37.187.137.238]:54026 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751800AbcDVXb5 (ORCPT ); Fri, 22 Apr 2016 19:31:57 -0400 Date: Sat, 23 Apr 2016 01:31:44 +0200 From: Alexandre Belloni To: =?iso-8859-1?Q?Myl=E8ne?= Josserand Cc: rtc-linux@googlegroups.com, Alessandro Zummo , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] rtc: rv3029: Removes some checks and warnings Message-ID: <20160422233144.GG17051@piout.net> References: <20160422232946.GF17051@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160422232946.GF17051@piout.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/04/2016 at 01:29:46 +0200, Alexandre Belloni wrote : > Hi, > > On 21/04/2016 at 20:24:17 +0200, Mylène Josserand wrote : > > @@ -829,8 +829,6 @@ static void rv3029_unregister_driver(void) > > > > static int rv3049_probe(struct spi_device *spi) > > { > > - int res; > > - unsigned int tmp; > > Well, you just introduced those variables in the previous patch. > And I forgot to add that you still have a few checkpatch warnings to remove while at it: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #129: FILE: drivers/rtc/rtc-rv3029c2.c:129: + unsigned len) WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #141: FILE: drivers/rtc/rtc-rv3029c2.c:141: + unsigned len) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com