From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e19.ny.us.ibm.com ([129.33.205.209]:48838 "EHLO e19.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752836AbcDXRxZ (ORCPT ); Sun, 24 Apr 2016 13:53:25 -0400 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 24 Apr 2016 13:53:24 -0400 Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 79C576E803C for ; Sun, 24 Apr 2016 13:53:06 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u3OHrLxh40108088 for ; Sun, 24 Apr 2016 17:53:21 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u3OHrLaH005792 for ; Sun, 24 Apr 2016 13:53:21 -0400 Date: Sun, 24 Apr 2016 10:53:55 -0700 From: "Paul E. McKenney" Subject: Re: [PATCH v3 1/3] qqz: Improve accuracy of cross-links Message-ID: <20160424175355.GT3756@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <571C1843.1060906@gmail.com> <571C1C8F.9000602@gmail.com> <571C42A1.8060201@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <571C42A1.8060201@gmail.com> Sender: perfbook-owner@vger.kernel.org List-ID: To: Akira Yokosawa Cc: perfbook@vger.kernel.org On Sun, Apr 24, 2016 at 12:50:57PM +0900, Akira Yokosawa wrote: > On 2016/04/24 10:08, Akira Yokosawa wrote: > >>From 6ecb00b37832372d18cdc7ff5eaea9a53eab3cb9 Mon Sep 17 00:00:00 2001 > > From: Akira Yokosawa > > Date: Sun, 24 Apr 2016 08:19:20 +0900 > > Subject: [PATCH v3 1/3] qqz: Improve accuracy of cross-links > > > > In commit 33b93f8258f5 ("qqz: Cross-link questions and answers"), > > cross-links of quick quizzes and their answers were implemented. > > However it uses the \stepcounter{} command, and direct references > > of 'quickquizctr' counter is not output to the .aux file. > > The symptom is when you click on a hyperlink in the resulting PDF, > > you jump to a random nearby label such as that of Figure, Table, > > or Section, etc. which happens just before the \label{} using > > 'quickquizctr'. > > > > By using \refstepcounter{} instead and using 2 counters > > 'quickquizctr' and 'quickquizctrC' ('C' stands for 'Chapter'), > > each of which is automatically reset at a new chapter and > > a new section respectively, and defining \theHNum at the head > > of qqz.sty, then redefining it within the \QuickQuizAnsers > > command, matching QQ.n.m's and QQA.n.m's are output to the .aux > > file correctly. > > > > By applying this change, resulting hyperlinks become to jump to > > places almost exactly where you'd expect. > > > > This change may have the effect of increasing the required number > > of 'pdflatex' iterations to get a final result. The following > > commit will take care of it. > > > > This commit also updates the copyright notices in the header, > > including the name of Paolo Bonzini who authored the commit > > mentioned above. > > > > Signed-off-by: Akira Yokosawa > > Hi, Paul. > > I noticed there really is a change in the behavior of hyperref's of > Chapters. They used to jump to the top of the pages, but after > this patch is applied, they jump to the bottom of the Chapter titles. > So you need to scroll a little to see the title of the Chapters. > > I think this is a regression caused by this patch. I believe that it always did that. Let me check... And yes, same behavior before and after the patch. The chapter hyperrefs put you just after the chapter heading. > If you do think so, please keep from pushing this series out. > > Or the benefit of the patch is big enough compared to the change > of the behavior? The benefit is large, and on my system, the chapter behavior does not change. So I am keeping the patches. It would of course be nice if the chapter hyperrefs pointed to just before the chapter heading (or to the beginning of the page. But given that no one has complained, this is not high priority. Thanx, Paul