From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Mon, 25 Apr 2016 09:03:44 +0000 Subject: Re: [PATCH v2 3/8] drm/qxl: Change drm_fb_helper_sys_*() calls to sys_*() Message-Id: <20160425090344.GP2510@phenom.ffwll.local> List-Id: References: <1461530942-22485-1-git-send-email-noralf@tronnes.org> <1461530942-22485-4-git-send-email-noralf@tronnes.org> In-Reply-To: <1461530942-22485-4-git-send-email-noralf@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com On Sun, Apr 24, 2016 at 10:48:57PM +0200, Noralf Tr=F8nnes wrote: > Now that drm_fb_helper gets deferred io support, the > drm_fb_helper_sys_{fillrect,copyarea,imageblit} functions will schedule > a worker that will call the (struct drm_framebuffer *)->funcs->dirty() > function. This will break this driver so use the > sys_{fillrect,copyarea,imageblit} functions directly. >=20 > Signed-off-by: Noralf Tr=F8nnes For patches 2&3: Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/qxl/qxl_fb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c > index 7136e52..06f032d 100644 > --- a/drivers/gpu/drm/qxl/qxl_fb.c > +++ b/drivers/gpu/drm/qxl/qxl_fb.c > @@ -199,7 +199,7 @@ static void qxl_fb_fillrect(struct fb_info *info, > { > struct qxl_fbdev *qfbdev =3D info->par; > =20 > - drm_fb_helper_sys_fillrect(info, rect); > + sys_fillrect(info, rect); > qxl_dirty_update(qfbdev, rect->dx, rect->dy, rect->width, > rect->height); > } > @@ -209,7 +209,7 @@ static void qxl_fb_copyarea(struct fb_info *info, > { > struct qxl_fbdev *qfbdev =3D info->par; > =20 > - drm_fb_helper_sys_copyarea(info, area); > + sys_copyarea(info, area); > qxl_dirty_update(qfbdev, area->dx, area->dy, area->width, > area->height); > } > @@ -219,7 +219,7 @@ static void qxl_fb_imageblit(struct fb_info *info, > { > struct qxl_fbdev *qfbdev =3D info->par; > =20 > - drm_fb_helper_sys_imageblit(info, image); > + sys_imageblit(info, image); > qxl_dirty_update(qfbdev, image->dx, image->dy, image->width, > image->height); > } > --=20 > 2.2.2 >=20 --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 3/8] drm/qxl: Change drm_fb_helper_sys_*() calls to sys_*() Date: Mon, 25 Apr 2016 11:03:44 +0200 Message-ID: <20160425090344.GP2510@phenom.ffwll.local> References: <1461530942-22485-1-git-send-email-noralf@tronnes.org> <1461530942-22485-4-git-send-email-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x232.google.com (mail-wm0-x232.google.com [IPv6:2a00:1450:400c:c09::232]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6256E6E541 for ; Mon, 25 Apr 2016 09:03:49 +0000 (UTC) Received: by mail-wm0-x232.google.com with SMTP id v188so89434371wme.1 for ; Mon, 25 Apr 2016 02:03:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1461530942-22485-4-git-send-email-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBBcHIgMjQsIDIwMTYgYXQgMTA6NDg6NTdQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IE5vdyB0aGF0IGRybV9mYl9oZWxwZXIgZ2V0cyBkZWZlcnJlZCBpbyBzdXBwb3J0 LCB0aGUKPiBkcm1fZmJfaGVscGVyX3N5c197ZmlsbHJlY3QsY29weWFyZWEsaW1hZ2VibGl0fSBm dW5jdGlvbnMgd2lsbCBzY2hlZHVsZQo+IGEgd29ya2VyIHRoYXQgd2lsbCBjYWxsIHRoZSAoc3Ry dWN0IGRybV9mcmFtZWJ1ZmZlciAqKS0+ZnVuY3MtPmRpcnR5KCkKPiBmdW5jdGlvbi4gVGhpcyB3 aWxsIGJyZWFrIHRoaXMgZHJpdmVyIHNvIHVzZSB0aGUKPiBzeXNfe2ZpbGxyZWN0LGNvcHlhcmVh LGltYWdlYmxpdH0gZnVuY3Rpb25zIGRpcmVjdGx5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IE5vcmFs ZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgoKRm9yIHBhdGNoZXMgMiYzOiBSZXZpZXdl ZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9xeGwvcXhsX2ZiLmMgfCA2ICsrKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwg MyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vcXhsL3F4bF9mYi5jIGIvZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfZmIuYwo+IGlu ZGV4IDcxMzZlNTIuLjA2ZjAzMmQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3F4bC9x eGxfZmIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2ZiLmMKPiBAQCAtMTk5LDcg KzE5OSw3IEBAIHN0YXRpYyB2b2lkIHF4bF9mYl9maWxscmVjdChzdHJ1Y3QgZmJfaW5mbyAqaW5m bywKPiAgewo+ICAJc3RydWN0IHF4bF9mYmRldiAqcWZiZGV2ID0gaW5mby0+cGFyOwo+ICAKPiAt CWRybV9mYl9oZWxwZXJfc3lzX2ZpbGxyZWN0KGluZm8sIHJlY3QpOwo+ICsJc3lzX2ZpbGxyZWN0 KGluZm8sIHJlY3QpOwo+ICAJcXhsX2RpcnR5X3VwZGF0ZShxZmJkZXYsIHJlY3QtPmR4LCByZWN0 LT5keSwgcmVjdC0+d2lkdGgsCj4gIAkJCSByZWN0LT5oZWlnaHQpOwo+ICB9Cj4gQEAgLTIwOSw3 ICsyMDksNyBAQCBzdGF0aWMgdm9pZCBxeGxfZmJfY29weWFyZWEoc3RydWN0IGZiX2luZm8gKmlu Zm8sCj4gIHsKPiAgCXN0cnVjdCBxeGxfZmJkZXYgKnFmYmRldiA9IGluZm8tPnBhcjsKPiAgCj4g LQlkcm1fZmJfaGVscGVyX3N5c19jb3B5YXJlYShpbmZvLCBhcmVhKTsKPiArCXN5c19jb3B5YXJl YShpbmZvLCBhcmVhKTsKPiAgCXF4bF9kaXJ0eV91cGRhdGUocWZiZGV2LCBhcmVhLT5keCwgYXJl YS0+ZHksIGFyZWEtPndpZHRoLAo+ICAJCQkgYXJlYS0+aGVpZ2h0KTsKPiAgfQo+IEBAIC0yMTks NyArMjE5LDcgQEAgc3RhdGljIHZvaWQgcXhsX2ZiX2ltYWdlYmxpdChzdHJ1Y3QgZmJfaW5mbyAq aW5mbywKPiAgewo+ICAJc3RydWN0IHF4bF9mYmRldiAqcWZiZGV2ID0gaW5mby0+cGFyOwo+ICAK PiAtCWRybV9mYl9oZWxwZXJfc3lzX2ltYWdlYmxpdChpbmZvLCBpbWFnZSk7Cj4gKwlzeXNfaW1h Z2VibGl0KGluZm8sIGltYWdlKTsKPiAgCXF4bF9kaXJ0eV91cGRhdGUocWZiZGV2LCBpbWFnZS0+ ZHgsIGltYWdlLT5keSwgaW1hZ2UtPndpZHRoLAo+ICAJCQkgaW1hZ2UtPmhlaWdodCk7Cj4gIH0K PiAtLSAKPiAyLjIuMgo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754203AbcDYJDu (ORCPT ); Mon, 25 Apr 2016 05:03:50 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35852 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753879AbcDYJDs (ORCPT ); Mon, 25 Apr 2016 05:03:48 -0400 Date: Mon, 25 Apr 2016 11:03:44 +0200 From: Daniel Vetter To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, daniel@ffwll.ch, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/8] drm/qxl: Change drm_fb_helper_sys_*() calls to sys_*() Message-ID: <20160425090344.GP2510@phenom.ffwll.local> Mail-Followup-To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, laurent.pinchart@ideasonboard.com, tomi.valkeinen@ti.com, linux-kernel@vger.kernel.org References: <1461530942-22485-1-git-send-email-noralf@tronnes.org> <1461530942-22485-4-git-send-email-noralf@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1461530942-22485-4-git-send-email-noralf@tronnes.org> X-Operating-System: Linux phenom 4.4.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 24, 2016 at 10:48:57PM +0200, Noralf Trønnes wrote: > Now that drm_fb_helper gets deferred io support, the > drm_fb_helper_sys_{fillrect,copyarea,imageblit} functions will schedule > a worker that will call the (struct drm_framebuffer *)->funcs->dirty() > function. This will break this driver so use the > sys_{fillrect,copyarea,imageblit} functions directly. > > Signed-off-by: Noralf Trønnes For patches 2&3: Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/qxl/qxl_fb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c > index 7136e52..06f032d 100644 > --- a/drivers/gpu/drm/qxl/qxl_fb.c > +++ b/drivers/gpu/drm/qxl/qxl_fb.c > @@ -199,7 +199,7 @@ static void qxl_fb_fillrect(struct fb_info *info, > { > struct qxl_fbdev *qfbdev = info->par; > > - drm_fb_helper_sys_fillrect(info, rect); > + sys_fillrect(info, rect); > qxl_dirty_update(qfbdev, rect->dx, rect->dy, rect->width, > rect->height); > } > @@ -209,7 +209,7 @@ static void qxl_fb_copyarea(struct fb_info *info, > { > struct qxl_fbdev *qfbdev = info->par; > > - drm_fb_helper_sys_copyarea(info, area); > + sys_copyarea(info, area); > qxl_dirty_update(qfbdev, area->dx, area->dy, area->width, > area->height); > } > @@ -219,7 +219,7 @@ static void qxl_fb_imageblit(struct fb_info *info, > { > struct qxl_fbdev *qfbdev = info->par; > > - drm_fb_helper_sys_imageblit(info, image); > + sys_imageblit(info, image); > qxl_dirty_update(qfbdev, image->dx, image->dy, image->width, > image->height); > } > -- > 2.2.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch