From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Date: Mon, 25 Apr 2016 09:11:29 +0000 Subject: Re: [patch] drm: atmel-hlcdc: fix a NULL check Message-Id: <20160425091129.GN32731@imgtec.com> List-Id: References: <20160425090454.GA25366@mwanda> In-Reply-To: <20160425090454.GA25366@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org On Mon, Apr 25, 2016 at 12:04:54PM +0300, Dan Carpenter wrote: > If kmalloc() returned NULL we would end up dereferencing "state" a > couple lines later. > > Signed-off-by: Dan Carpenter Reviewed-by: Eric Engestrom From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [patch] drm: atmel-hlcdc: fix a NULL check Date: Mon, 25 Apr 2016 10:11:29 +0100 Message-ID: <20160425091129.GN32731@imgtec.com> References: <20160425090454.GA25366@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by gabe.freedesktop.org (Postfix) with ESMTP id C74C76E547 for ; Mon, 25 Apr 2016 09:11:07 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160425090454.GA25366@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBcHIgMjUsIDIwMTYgYXQgMTI6MDQ6NTRQTSArMDMwMCwgRGFuIENhcnBlbnRlciB3 cm90ZToKPiBJZiBrbWFsbG9jKCkgcmV0dXJuZWQgTlVMTCB3ZSB3b3VsZCBlbmQgdXAgZGVyZWZl cmVuY2luZyAic3RhdGUiIGEKPiBjb3VwbGUgbGluZXMgbGF0ZXIuCj4gCj4gU2lnbmVkLW9mZi1i eTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgoKUmV2aWV3ZWQtYnk6 IEVyaWMgRW5nZXN0cm9tIDxlcmljLmVuZ2VzdHJvbUBpbWd0ZWMuY29tPgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753792AbcDYJLK (ORCPT ); Mon, 25 Apr 2016 05:11:10 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:51731 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753675AbcDYJLI (ORCPT ); Mon, 25 Apr 2016 05:11:08 -0400 Date: Mon, 25 Apr 2016 10:11:29 +0100 From: Eric Engestrom To: Dan Carpenter CC: Boris Brezillon , , , Subject: Re: [patch] drm: atmel-hlcdc: fix a NULL check Message-ID: <20160425091129.GN32731@imgtec.com> References: <20160425090454.GA25366@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20160425090454.GA25366@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [10.60.4.28] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 25, 2016 at 12:04:54PM +0300, Dan Carpenter wrote: > If kmalloc() returned NULL we would end up dereferencing "state" a > couple lines later. > > Signed-off-by: Dan Carpenter Reviewed-by: Eric Engestrom