From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] tpm: use devm_add_action_or_reset Date: Mon, 25 Apr 2016 14:57:18 -0600 Message-ID: <20160425205718.GD15367@obsidianresearch.com> References: <1461617198-32351-1-git-send-email-sudipm.mukherjee@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1461617198-32351-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Sudip Mukherjee Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Apr 25, 2016 at 09:46:38PM +0100, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling the cleanup function > in the error path. Lets use the helper function devm_add_action_or_reset() > and return directly as we know the cleanup has been done by the helper. Seems reasonable to me. Reviewed-by: Jason Gunthorpe ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965058AbcDYU51 (ORCPT ); Mon, 25 Apr 2016 16:57:27 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:37963 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964836AbcDYU50 (ORCPT ); Mon, 25 Apr 2016 16:57:26 -0400 Date: Mon, 25 Apr 2016 14:57:18 -0600 From: Jason Gunthorpe To: Sudip Mukherjee Cc: Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net Subject: Re: [PATCH] tpm: use devm_add_action_or_reset Message-ID: <20160425205718.GD15367@obsidianresearch.com> References: <1461617198-32351-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461617198-32351-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 25, 2016 at 09:46:38PM +0100, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling the cleanup function > in the error path. Lets use the helper function devm_add_action_or_reset() > and return directly as we know the cleanup has been done by the helper. Seems reasonable to me. Reviewed-by: Jason Gunthorpe