From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752201AbcDZOP5 (ORCPT ); Tue, 26 Apr 2016 10:15:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:43999 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752006AbcDZOP4 (ORCPT ); Tue, 26 Apr 2016 10:15:56 -0400 Date: Tue, 26 Apr 2016 16:15:53 +0200 From: Petr Mladek To: Sergey Senozhatsky Cc: Andrew Morton , Jan Kara , Tejun Heo , Tetsuo Handa , linux-kernel@vger.kernel.org, Byungchul Park , Sergey Senozhatsky Subject: Re: [PATCH] printk: make printk.synchronous param rw Message-ID: <20160426141553.GJ2749@pathway.suse.cz> References: <1461333180-2897-4-git-send-email-sergey.senozhatsky@gmail.com> <1461423665-2227-1-git-send-email-sergey.senozhatsky@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461423665-2227-1-git-send-email-sergey.senozhatsky@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 2016-04-24 00:01:05, Sergey Senozhatsky wrote: > Change `synchronous' printk param to be RW, so user space > can change printk mode back and forth to/from sync mode > (which is considered to be more reliable). > > Signed-off-by: Sergey Senozhatsky > Reviewed-by: Jan Kara > --- > > -- added Jan's Reviewed-by > -- factored out async printk checks to can_printk_async() > > kernel/printk/printk.c | 56 ++++++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 45 insertions(+), 11 deletions(-) > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index 89f5441..9345a29 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -2757,6 +2759,13 @@ static int __init printk_late_init(void) > late_initcall(printk_late_init); > > #if defined CONFIG_PRINTK > +/* > + * Prevent starting printk_kthread from start_kernel()->parse_args(). > + * It's not possible at this stage. Instead, do it via the inticall ^^^^^^^^ s/inticall/initcall/ Otherwise, it looks fine. I like the series and keep my fingers crossed. Reviewed-by: Petr Mladek Best Regards, Petr