From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC v2 5/8] drm/fence: add in-fences support Date: Tue, 26 Apr 2016 19:26:21 +0300 Message-ID: <20160426162621.GU4329@intel.com> References: <1461623608-29538-1-git-send-email-gustavo@padovan.org> <1461623608-29538-6-git-send-email-gustavo@padovan.org> <20160426101050.GN4329@intel.com> <20160426141422.GG7857@joana> <20160426143635.GW8291@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 98E986E879 for ; Tue, 26 Apr 2016 16:26:25 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160426143635.GW8291@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , Gustavo Padovan , Daniel Stone , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBcHIgMjYsIDIwMTYgYXQgMDQ6MzY6MzZQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIEFwciAyNiwgMjAxNiBhdCAxMToxNDoyMkFNIC0wMzAwLCBHdXN0YXZv IFBhZG92YW4gd3JvdGU6Cj4gPiAyMDE2LTA0LTI2IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Ogo+ID4gCj4gPiA+IE9uIE1vbiwgQXByIDI1LCAyMDE2IGF0 IDA3OjMzOjI1UE0gLTAzMDAsIEd1c3Rhdm8gUGFkb3ZhbiB3cm90ZToKPiA+ID4gPiBGcm9tOiBH dXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY28udWs+Cj4gPiA+ID4g Cj4gPiA+ID4gVGhlcmUgaXMgbm93IGEgbmV3IHByb3BlcnR5IGNhbGxlZCBGRU5DRV9GRCBhdHRh Y2hlZCB0byBldmVyeSBwbGFuZQo+ID4gPiA+IHN0YXRlIHRoYXQgcmVjZWl2ZXMgdGhlIHN5bmNf ZmlsZSBmZCBmcm9tIHVzZXJzcGFjZSB2aWEgdGhlIGF0b21pYyBjb21taXQKPiA+ID4gPiBJT0NU TC4KPiA+ID4gCj4gPiA+IEkgc3RpbGwgZG9uJ3QgbGlrZSB0aGlzIHByb3BlcnR5IGFidXNlLiBB bHNvIHdpdGggYXRvbWljLCBhbGwgcGFzc2VkCj4gPiA+IGZlbmNlcyBtdXN0IGJlIHdhaXRlZCB1 cG9uIGJlZm9yZSBhbnl0aGluZyBpcyBkb25lLCBzbyBhdHRhY2hpbmcgdGhlbQo+ID4gPiB0byBw bGFuZXMgc2VlbXMgbGlrZSBpdCBtaWdodCBqdXN0IGdpdmUgcGVvcGxlIHRoZSB3cm9uZyBpZGVh Lgo+ID4gCj4gPiBJJ20gYWN0dWFsbHkgZmluZSB3aXRoIHRoaXMgYXMgcHJvcGVydHksIGJ1dCBh bm90aGVyIHNvbHV0aW9ucyBpcyB1c2UKPiA+IGFuIGFycmF5IG9mIHtwbGFuZSwgZmVuY2VfZmR9 IGFuZCBleHRlbmQgZHJtX2F0b21pY19pb2N0bCBhcmdzIGp1c3QgbGlrZQo+ID4gd2UgaGF2ZSBk b25lIGZvciBvdXQgZmVuY2VzLiBIb3dldmVyIHRoZSBGRU5DRV9GRCBwcm9wZXJ0eSBpcyBlYXNp ZXIgdG8KPiA+IGhhbmRsZSBpbiB1c2Vyc3BhY2UgdGhhbiB0aGUgYXJyYXkuIEFueSBvdGhlciBp ZGVhPwo+IAo+IEltbyBGRU5DRV9GRCBpcyBwZXJmZWN0bHkgZmluZS4gQnV0IHdoYXQncyB0aGUg Y29uY2VybiBhcm91bmQgZ2l2aW5nCj4gcGVvcGxlIHRoZSB3cm9uZyBpZGVhIHdpdGggYXR0YWNo aW5nIGZlbmNlcyB0byBwbGFuZXM/IEZvciBub25ibG9ja2luZwo+IGNvbW1pdHMgd2UgbmVlZCB0 byBzdG9yZSB0aGVtIHNvbWV3aGVyZSBmb3IgdGhlIHdvcmtlciwgZHJtX3BsYW5lX3N0YXRlCj4g c2VlbXMgbGlrZSBhbiBhcyBnb29kIHBsYWNlIGFzIGFueSBvdGhlci4KCkl0IGdpdmVzIHRoZSBp bXByZXNzaW9uIHRoYXQgZWFjaCBwbGFuZSBtaWdodCBmbGlwIGFzIHNvb24gYXMgaXRzIGZlbmNl CnNpZ25hbHMuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752636AbcDZQ01 (ORCPT ); Tue, 26 Apr 2016 12:26:27 -0400 Received: from mga01.intel.com ([192.55.52.88]:7399 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbcDZQ00 (ORCPT ); Tue, 26 Apr 2016 12:26:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,537,1455004800"; d="scan'208";a="692589070" Date: Tue, 26 Apr 2016 19:26:21 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Gustavo Padovan , Gustavo Padovan , Daniel Stone , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , John Harrison Subject: Re: [RFC v2 5/8] drm/fence: add in-fences support Message-ID: <20160426162621.GU4329@intel.com> References: <1461623608-29538-1-git-send-email-gustavo@padovan.org> <1461623608-29538-6-git-send-email-gustavo@padovan.org> <20160426101050.GN4329@intel.com> <20160426141422.GG7857@joana> <20160426143635.GW8291@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160426143635.GW8291@phenom.ffwll.local> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2016 at 04:36:36PM +0200, Daniel Vetter wrote: > On Tue, Apr 26, 2016 at 11:14:22AM -0300, Gustavo Padovan wrote: > > 2016-04-26 Ville Syrjälä : > > > > > On Mon, Apr 25, 2016 at 07:33:25PM -0300, Gustavo Padovan wrote: > > > > From: Gustavo Padovan > > > > > > > > There is now a new property called FENCE_FD attached to every plane > > > > state that receives the sync_file fd from userspace via the atomic commit > > > > IOCTL. > > > > > > I still don't like this property abuse. Also with atomic, all passed > > > fences must be waited upon before anything is done, so attaching them > > > to planes seems like it might just give people the wrong idea. > > > > I'm actually fine with this as property, but another solutions is use > > an array of {plane, fence_fd} and extend drm_atomic_ioctl args just like > > we have done for out fences. However the FENCE_FD property is easier to > > handle in userspace than the array. Any other idea? > > Imo FENCE_FD is perfectly fine. But what's the concern around giving > people the wrong idea with attaching fences to planes? For nonblocking > commits we need to store them somewhere for the worker, drm_plane_state > seems like an as good place as any other. It gives the impression that each plane might flip as soon as its fence signals. -- Ville Syrjälä Intel OTC