From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC v2 7/8] drm/fence: add fence timeline to drm_crtc Date: Tue, 26 Apr 2016 19:34:32 +0300 Message-ID: <20160426163432.GV4329@intel.com> References: <1461623608-29538-1-git-send-email-gustavo@padovan.org> <1461623608-29538-8-git-send-email-gustavo@padovan.org> <20160426101200.GO4329@intel.com> <20160426142306.GH7857@joana> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id B30D86E87E for ; Tue, 26 Apr 2016 16:34:36 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160426142306.GH7857@joana> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan Cc: Daniel Stone , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Riley Andrews , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Daniel Vetter , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBcHIgMjYsIDIwMTYgYXQgMTE6MjM6MDZBTSAtMDMwMCwgR3VzdGF2byBQYWRvdmFu IHdyb3RlOgo+IDIwMTYtMDQtMjYgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT46Cj4gCj4gPiBPbiBNb24sIEFwciAyNSwgMjAxNiBhdCAwNzozMzoyN1BNIC0w MzAwLCBHdXN0YXZvIFBhZG92YW4gd3JvdGU6Cj4gPiA+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8 Z3VzdGF2by5wYWRvdmFuQGNvbGxhYm9yYS5jby51az4KPiA+ID4gCj4gPiA+IENyZWF0ZSBvbmUg dGltZWxpbmUgY29udGV4dCBmb3IgZWFjaCBDUlRDIHRvIGJlIGFibGUgdG8gaGFuZGxlIG91dC1m ZW5jZXMKPiA+ID4gYW5kIHNpZ25hbCB0aGVtLiBJdCBhZGRzIGEgZmV3IG1lbWJlcnMgdG8gc3Ry dWN0IGRybV9jcnRjOiBmZW5jZV9jb250ZXh0LAo+ID4gPiB3aGVyZSB3ZSBzdG9yZSB0aGUgY29u dGV4dCB3ZSBnZXQgZnJvbSBmZW5jZV9jb250ZXh0X2FsbG9jKCksIHRoZQo+ID4gPiBmZW5jZSBz ZXFubyBhbmQgdGhlIGZlbmNlIGxvY2ssIHRoYXQgd2UgcGFzcyBpbiBmZW5jZV9pbml0KCkgdG8g YmUKPiA+ID4gdXNlZCBieSB0aGUgZmVuY2UuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBH dXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY28udWs+Cj4gPiA+IC0t LQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgfCAyOSArKysrKysrKysrKysrKysr KysrKysrKysrKysrKwo+ID4gPiAgaW5jbHVkZS9kcm0vZHJtX2NydGMuaCAgICAgfCAxOSArKysr KysrKysrKysrKysrKysrCj4gPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDQ4IGluc2VydGlvbnMoKykK PiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gPiA+IGluZGV4IDY1MjEyY2UuLmNmOTc1MGEgMTAw NjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gPiA+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gPiA+IEBAIC02NTksNiArNjU5LDMyIEBAIHN0YXRp YyB1bnNpZ25lZCBpbnQgZHJtX251bV9jcnRjcyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4g PiAgCXJldHVybiBudW07Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gK3N0YXRpYyBjb25zdCBjaGFy ICpkcm1fY3J0Y19mZW5jZV9nZXRfZHJpdmVyX25hbWUoc3RydWN0IGZlbmNlICpmZW5jZSkKPiA+ ID4gK3sKPiA+ID4gKwlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSBmZW5jZV90b19jcnRjKGZlbmNl KTsKPiA+ID4gKwo+ID4gPiArCXJldHVybiBjcnRjLT5kZXYtPmRyaXZlci0+bmFtZTsKPiA+ID4g K30KPiA+ID4gKwo+ID4gPiArc3RhdGljIGNvbnN0IGNoYXIgKmRybV9jcnRjX2ZlbmNlX2dldF90 aW1lbGluZV9uYW1lKHN0cnVjdCBmZW5jZSAqZmVuY2UpCj4gPiA+ICt7Cj4gPiA+ICsJc3RydWN0 IGRybV9jcnRjICpjcnRjID0gZmVuY2VfdG9fY3J0YyhmZW5jZSk7Cj4gPiA+ICsKPiA+ID4gKwly ZXR1cm4gY3J0Yy0+bmFtZTsKPiA+ID4gK30KPiA+IAo+ID4gSXMgdGhhdCBleHBvcnRlZCB0byB1 c2Vyc3BhY2U/IGNydGMtPm5hbWUgaXMgYW4gaW50ZXJuYWwgdGhpbmcsIG5vdAo+ID4gbWVhbnQg Zm9yIG91dHNpZGUgY29uc3VtcHRpb24uCj4gCj4gTm8uIEhvd2V2ZXIgaXQgbWF5IGJlIGV4cG9y dGVkIHZpYSBkZWJ1Z2ZzIGF0IHNvbWUgcG9pbnQuIE1heWJlIGhhdmUKPiBkcm1fY3J0Yy0+dGlt ZWxpbmVfbmFtZSB3aGljaCBoYXMgdGhlIG9ial9pZCBpbnN0ZWFkLCBlZy4sICJkcm1fY3J0YzE5 IiA/CgpJJ20gZmluZSBlaXRoZXIgd2F5IGlmIGl0J3MgYW4gaW50ZXJuYWwgdGhpbmcuIFNvIHBp Y2sgd2hpY2hldmVyIG1ha2VzCnBlb3BsZSdzIGxpZmUgZWFzaWVyIEkgZ3Vlc3MuCgotLSAKVmls bGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752290AbcDZQfJ (ORCPT ); Tue, 26 Apr 2016 12:35:09 -0400 Received: from mga02.intel.com ([134.134.136.20]:55014 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843AbcDZQfI (ORCPT ); Tue, 26 Apr 2016 12:35:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,537,1455004800"; d="scan'208";a="966938014" Date: Tue, 26 Apr 2016 19:34:32 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Gustavo Padovan Cc: Gustavo Padovan , Daniel Stone , Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , John Harrison Subject: Re: [RFC v2 7/8] drm/fence: add fence timeline to drm_crtc Message-ID: <20160426163432.GV4329@intel.com> References: <1461623608-29538-1-git-send-email-gustavo@padovan.org> <1461623608-29538-8-git-send-email-gustavo@padovan.org> <20160426101200.GO4329@intel.com> <20160426142306.GH7857@joana> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160426142306.GH7857@joana> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2016 at 11:23:06AM -0300, Gustavo Padovan wrote: > 2016-04-26 Ville Syrjälä : > > > On Mon, Apr 25, 2016 at 07:33:27PM -0300, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > Create one timeline context for each CRTC to be able to handle out-fences > > > and signal them. It adds a few members to struct drm_crtc: fence_context, > > > where we store the context we get from fence_context_alloc(), the > > > fence seqno and the fence lock, that we pass in fence_init() to be > > > used by the fence. > > > > > > Signed-off-by: Gustavo Padovan > > > --- > > > drivers/gpu/drm/drm_crtc.c | 29 +++++++++++++++++++++++++++++ > > > include/drm/drm_crtc.h | 19 +++++++++++++++++++ > > > 2 files changed, 48 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > > > index 65212ce..cf9750a 100644 > > > --- a/drivers/gpu/drm/drm_crtc.c > > > +++ b/drivers/gpu/drm/drm_crtc.c > > > @@ -659,6 +659,32 @@ static unsigned int drm_num_crtcs(struct drm_device *dev) > > > return num; > > > } > > > > > > +static const char *drm_crtc_fence_get_driver_name(struct fence *fence) > > > +{ > > > + struct drm_crtc *crtc = fence_to_crtc(fence); > > > + > > > + return crtc->dev->driver->name; > > > +} > > > + > > > +static const char *drm_crtc_fence_get_timeline_name(struct fence *fence) > > > +{ > > > + struct drm_crtc *crtc = fence_to_crtc(fence); > > > + > > > + return crtc->name; > > > +} > > > > Is that exported to userspace? crtc->name is an internal thing, not > > meant for outside consumption. > > No. However it may be exported via debugfs at some point. Maybe have > drm_crtc->timeline_name which has the obj_id instead, eg., "drm_crtc19" ? I'm fine either way if it's an internal thing. So pick whichever makes people's life easier I guess. -- Ville Syrjälä Intel OTC