All of lore.kernel.org
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave-h16yJtLeMjHk1uMJSBkQmQ@public.gmane.org>
To: "Austin S. Hemmelgarn"
	<ahferroin7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Julius Werner <jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Gwendal Grignou <gwendal-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Karel Zak <kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] block: partitions: efi: Always check for alternative GPT at end of drive
Date: Tue, 26 Apr 2016 11:10:18 -0700	[thread overview]
Message-ID: <20160426181018.GA16601@linux-uzut.site> (raw)
In-Reply-To: <571F7D6D.8020209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Tue, 26 Apr 2016, Austin S. Hemmelgarn wrote:

>At the absolute minimum, we should be logging (at least at a warning 
>level) that we had to fall back the the backup GPT.  If somebody is 
>dealing with a disk that had a torn write to the primary GPT, that's 
>one thing, but this could also be caused by any number of other 
>problems (hardware issues, malicious intent, etc), and we need to log 
>that we detected corrupted data.

We already complain about corrupted primary gpt (at a warn level), and
there's also plenty of verbosity about differences between primary and
backup (see compare_gpts()), or are you referring to something else?

Thanks,
Davidlohr

WARNING: multiple messages have this Message-ID (diff)
From: Davidlohr Bueso <dave@stgolabs.net>
To: "Austin S. Hemmelgarn" <ahferroin7@gmail.com>
Cc: Julius Werner <jwerner@chromium.org>,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-block@vger.kernel.org,
	Gwendal Grignou <gwendal@chromium.org>,
	Doug Anderson <dianders@chromium.org>,
	Karel Zak <kzak@redhat.com>
Subject: Re: [PATCH] block: partitions: efi: Always check for alternative GPT at end of drive
Date: Tue, 26 Apr 2016 11:10:18 -0700	[thread overview]
Message-ID: <20160426181018.GA16601@linux-uzut.site> (raw)
In-Reply-To: <571F7D6D.8020209@gmail.com>

On Tue, 26 Apr 2016, Austin S. Hemmelgarn wrote:

>At the absolute minimum, we should be logging (at least at a warning 
>level) that we had to fall back the the backup GPT.  If somebody is 
>dealing with a disk that had a torn write to the primary GPT, that's 
>one thing, but this could also be caused by any number of other 
>problems (hardware issues, malicious intent, etc), and we need to log 
>that we detected corrupted data.

We already complain about corrupted primary gpt (at a warn level), and
there's also plenty of verbosity about differences between primary and
backup (see compare_gpts()), or are you referring to something else?

Thanks,
Davidlohr

  parent reply	other threads:[~2016-04-26 18:10 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26  1:06 [PATCH] block: partitions: efi: Always check for alternative GPT at end of drive Julius Werner
2016-04-26  1:06 ` Julius Werner
     [not found] ` <1461632806-5946-1-git-send-email-jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-04-26 10:20   ` Karel Zak
2016-04-26 10:20     ` Karel Zak
2016-04-26 18:33     ` Davidlohr Bueso
     [not found]       ` <20160426183353.GB16601-95RKjC4jbl+7r5TWoziOLQ@public.gmane.org>
2016-04-26 20:13         ` Julius Werner
2016-04-26 20:13           ` Julius Werner
2016-04-26 20:34       ` Elliott, Robert (Persistent Memory)
     [not found]         ` <94D0CD8314A33A4D9D801C0FE68B402963904365-wwDBVnaDRpYSZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2016-04-26 21:15           ` Davidlohr Bueso
2016-04-26 21:15             ` Davidlohr Bueso
     [not found]             ` <20160426211547.GC16601-95RKjC4jbl+7r5TWoziOLQ@public.gmane.org>
2016-04-26 21:51               ` Gwendal Grignou
2016-04-26 21:51                 ` Gwendal Grignou
     [not found]                 ` <CAMHSBOW7MBtpVPZdt8yGggUhxk_ca3U+w9Wc-vg5fX7G-jB6mQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-27 15:09                   ` Karel Zak
2016-04-27 15:09                     ` Karel Zak
2016-04-27 15:45                     ` Doug Anderson
     [not found]                     ` <20160427150913.m2vvhtriq27u65tk-xkT7n84Rsxv/9pzu0YdTqQ@public.gmane.org>
2016-04-27 21:44                       ` Julius Werner
2016-04-27 21:44                         ` Julius Werner
2016-04-27  6:00           ` Ard Biesheuvel
2016-04-27  6:00             ` Ard Biesheuvel
     [not found]             ` <CAKv+Gu9UnTnWQt7Q6p3CWbmn8sufcxgYcVo=KD68Wg1=1rrzdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-27 12:59               ` Austin S. Hemmelgarn
2016-04-27 12:59                 ` Austin S. Hemmelgarn
2016-04-26 14:38   ` Austin S. Hemmelgarn
2016-04-26 14:38     ` Austin S. Hemmelgarn
     [not found]     ` <571F7D6D.8020209-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-04-26 18:10       ` Davidlohr Bueso [this message]
2016-04-26 18:10         ` Davidlohr Bueso
     [not found]         ` <20160426181018.GA16601-95RKjC4jbl+7r5TWoziOLQ@public.gmane.org>
2016-04-26 19:27           ` Austin S. Hemmelgarn
2016-04-26 19:27             ` Austin S. Hemmelgarn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160426181018.GA16601@linux-uzut.site \
    --to=dave-h16yjtlemjhk1umjsbkqmq@public.gmane.org \
    --cc=ahferroin7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=gwendal-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.