From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
David Ahern <dsahern@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Alexei Starovoitov <ast@kernel.org>,
He Kuang <hekuang@huawei.com>, Jiri Olsa <jolsa@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Milian Wolff <milian.wolff@kdab.com>,
Namhyung Kim <namhyung@kernel.org>,
Stephane Eranian <eranian@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Vince Weaver <vincent.weaver@maine.edu>,
Wang Nan <wangnan0@huawei.com>, Zefan Li <lizefan@huawei.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl
Date: Tue, 26 Apr 2016 18:05:00 -0300 [thread overview]
Message-ID: <20160426210500.GK11033@kernel.org> (raw)
In-Reply-To: <CAE40pddVQPk+O5X=RcqgyYWY06pJMO+hBf7DjC0ugyZJaMRp_w@mail.gmail.com>
Em Tue, Apr 26, 2016 at 01:02:34PM -0700, Brendan Gregg escreveu:
> On Mon, Apr 25, 2016 at 5:49 PM, Brendan Gregg <brendan.d.gregg@gmail.com> wrote:
> > On Mon, Apr 25, 2016 at 5:47 PM, Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> wrote:
> >> Em Mon, Apr 25, 2016 at 05:44:00PM -0700, Alexei Starovoitov escreveu:
> >>> yep :)
> >>> hopefully Brendan can give it another spin.
> >>
> >> Agreed, and I'm calling it a day anyway, Brendan, please consider
> >> retesting, thanks,
> >
> > Will do, thanks!
>
> Looks good.
>
> I started with max depth = 512, and even that was still truncated, and
> had to profile again at 1024 to capture the full stacks. Seems to
> generally match the flame graph I generated with V1, which made me
> want to check that I'm running the new patch, and am:
>
> # grep six_hundred_forty_kb /proc/kallsyms
> ffffffff81c431e0 d six_hundred_forty_kb
>
> I was mucking around and was able to get "corrupted callchain.
> skipping..." errors, but these look to be expected -- that was
Yeah, thanks for testing!
And since you talked about userspace without frame pointers, have you
played with '--call-graph lbr'?
- Arnaldo
> profiling a binary (bash) that doesn't have frame pointers. Some perf
> script -D output:
>
> 16 3204735442777 0x18f0d8 [0x2030]: PERF_RECORD_SAMPLE(IP, 0x1):
> 18134/18134: 0xffffffff8118b6a4 period: 1001001 addr: 0
> ... FP chain: nr:1023
> ..... 0: ffffffffffffff80
> ..... 1: ffffffff8118b6a4
> ..... 2: ffffffff8118bc47
> ..... 3: ffffffff811d8c85
> ..... 4: ffffffff811b18f8
> ..... 5: ffffffff811b2a55
> ..... 6: ffffffff811b5ea0
> ..... 7: ffffffff810663c0
> ..... 8: ffffffff810666e0
> ..... 9: ffffffff817b9d28
> ..... 10: fffffffffffffe00
> ..... 11: 00000000004b45e2
> ..... 12: 000000000000610f
> ..... 13: 0000000000006110
> ..... 14: 0000000000006111
> ..... 15: 0000000000006112
> ..... 16: 0000000000006113
> ..... 17: 0000000000006114
> ..... 18: 0000000000006115
> ..... 19: 0000000000006116
> ..... 20: 0000000000006117
> [...]
> ..... 1021: 000000000000650b
> ..... 1022: 000000000000650c
> ... thread: bash:18134
> ...... dso: /lib/modules/4.6.0-rc5-virtual/build/vmlinux
> bash 18134 [016] 3204.735442: 1001001 cpu-clock:
>
> Brendan
next prev parent reply other threads:[~2016-04-26 21:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 22:47 [PATCH/RFC] perf core: Allow setting up max frame stack depth via sysctl Arnaldo Carvalho de Melo
2016-04-20 23:04 ` Alexei Starovoitov
2016-04-22 20:52 ` [PATCH/RFC v2] " Arnaldo Carvalho de Melo
2016-04-22 21:37 ` Alexei Starovoitov
2016-04-22 22:05 ` David Ahern
2016-04-22 22:18 ` Alexei Starovoitov
2016-04-25 16:14 ` Arnaldo Carvalho de Melo
2016-04-25 16:27 ` Arnaldo Carvalho de Melo
2016-04-25 19:22 ` Arnaldo Carvalho de Melo
2016-04-25 20:06 ` Alexei Starovoitov
2016-04-25 20:17 ` Arnaldo Carvalho de Melo
2016-04-25 21:59 ` Alexei Starovoitov
2016-04-25 23:41 ` Arnaldo Carvalho de Melo
2016-04-26 0:07 ` Alexei Starovoitov
2016-04-26 0:29 ` [PATCH/RFC v3] " Arnaldo Carvalho de Melo
2016-04-26 0:44 ` Alexei Starovoitov
2016-04-26 0:47 ` Arnaldo Carvalho de Melo
2016-04-26 0:49 ` Brendan Gregg
2016-04-26 16:33 ` Arnaldo Carvalho de Melo
2016-04-26 16:45 ` David Ahern
2016-04-27 13:20 ` Arnaldo Carvalho de Melo
2016-04-26 20:02 ` Brendan Gregg
2016-04-26 21:05 ` Arnaldo Carvalho de Melo [this message]
2016-04-26 21:55 ` Peter Zijlstra
2016-04-27 12:53 ` Arnaldo Carvalho de Melo
2016-04-26 21:58 ` Brendan Gregg
2016-04-26 22:10 ` Peter Zijlstra
2016-04-27 12:56 ` Arnaldo Carvalho de Melo
2016-04-26 21:58 ` Frederic Weisbecker
2016-04-27 12:53 ` Arnaldo Carvalho de Melo
2016-04-27 16:09 ` Frederic Weisbecker
2016-04-27 16:27 ` David Ahern
2016-04-27 15:39 ` [tip:perf/core] " tip-bot for Arnaldo Carvalho de Melo
2016-04-20 23:10 ` [PATCH/RFC] " David Ahern
2016-04-21 0:18 ` Arnaldo Carvalho de Melo
2016-04-21 10:48 ` Peter Zijlstra
2016-04-21 15:17 ` Arnaldo Carvalho de Melo
2016-04-21 15:42 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426210500.GK11033@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=brendan.d.gregg@gmail.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hekuang@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mhiramat@kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vincent.weaver@maine.edu \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.