All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Cc: Derek Straka <derek@asterius.io>
Subject: Re: [meta-oe][PATCH] fribidi: update to version 0.19.7
Date: Wed, 27 Apr 2016 09:45:00 +0200	[thread overview]
Message-ID: <20160427074500.GA2559@jama> (raw)
In-Reply-To: <1461351842-8783-1-git-send-email-derek@asterius.io>

[-- Attachment #1: Type: text/plain, Size: 3992 bytes --]

On Fri, Apr 22, 2016 at 03:04:02PM -0400, Derek Straka wrote:
> Signed-off-by: Derek Straka <derek@asterius.io>
> ---
>  meta-oe/recipes-devtools/libfribidi/fribidi_0.19.2.bb | 17 -----------------
>  meta-oe/recipes-devtools/libfribidi/fribidi_0.19.7.bb | 17 +++++++++++++++++
>  2 files changed, 17 insertions(+), 17 deletions(-)
>  delete mode 100644 meta-oe/recipes-devtools/libfribidi/fribidi_0.19.2.bb
>  create mode 100644 meta-oe/recipes-devtools/libfribidi/fribidi_0.19.7.bb
> 
> diff --git a/meta-oe/recipes-devtools/libfribidi/fribidi_0.19.2.bb b/meta-oe/recipes-devtools/libfribidi/fribidi_0.19.2.bb
> deleted file mode 100644
> index cb4bc24..0000000
> --- a/meta-oe/recipes-devtools/libfribidi/fribidi_0.19.2.bb
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -SUMMARY = "Fribidi library for bidirectional text"
> -SECTION = "libs"
> -PR = "r1"
> -LICENSE = "LGPLv2.1"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=7fbc338309ac38fefcd64b04bb903e34"
> -BBCLASSEXTEND = "native"
> -
> -PROVIDES = "libfribidi"
> -
> -inherit autotools lib_package pkgconfig
> -
> -CFLAGS_append = "  -DPAGE_SIZE=4096 "
> -
> -SRC_URI = "http://fribidi.org/download/fribidi-${PV}.tar.gz"
> -
> -SRC_URI[md5sum] = "626db17d2d99b43615ad9d12500f568a"
> -SRC_URI[sha256sum] = "49cf91586e48b52fe25872ff66c1da0dff0daac2593f9f300e2af12f44f64177"
> diff --git a/meta-oe/recipes-devtools/libfribidi/fribidi_0.19.7.bb b/meta-oe/recipes-devtools/libfribidi/fribidi_0.19.7.bb
> new file mode 100644
> index 0000000..02b8764
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/libfribidi/fribidi_0.19.7.bb
> @@ -0,0 +1,17 @@
> +SUMMARY = "Fribidi library for bidirectional text"
> +SECTION = "libs"
> +PR = "r1"

You can drop PR when upgrading PV.

Probably this change caused fbreader to fail:
| Compiling ZLTextParagraphBuilder.o ...In file included from /home/jenkins/oe/world/shr-core/tmp-glibc/sysroots/qemuarm/usr/include/fribidi/fribidi.h:35:0,
|                  from ZLTextParagraphBuilder.h:26,
|                  from ZLTextParagraphBuilder.cpp:30:
| /home/jenkins/oe/world/shr-core/tmp-glibc/sysroots/qemuarm/usr/include/fribidi/fribidi-common.h:61:20: fatal error: glib.h: No such file or directory
| compilation terminated.
| make[2]: *** [ZLTextParagraphBuilder.o] Error 1
| make[2]: Leaving directory `/home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/fbreader/0.12.10-r1/fbreader-0.12.10/zlibrary/text/src/area'
| make[1]: *** [.objects] Error 1
| make[1]: Leaving directory `/home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/fbreader/0.12.10-r1/fbreader-0.12.10/zlibrary/text'
| make: *** [all] Error 1
| ERROR: oe_runmake failed
| ERROR: Function failed: do_compile (log file is located at /home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/fbreader/0.12.10-r1/temp/log.do_compile.29262)
NOTE: recipe fbreader-0.12.10-r1: task do_compile: Failed

Can you check if fribidi should depend on glib-2.0 now? And also please send v2 with -M (adjust the -M parameter to detect rename if you used -M before).

Also add short summary explaining what was changed in COPYING change when you're changing its checksum.

> +LICENSE = "LGPLv2.1"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=a916467b91076e631dd8edb7424769c7"
> +BBCLASSEXTEND = "native"
> +
> +PROVIDES = "libfribidi"
> +
> +inherit autotools lib_package pkgconfig
> +
> +CFLAGS_append = "  -DPAGE_SIZE=4096 "
> +
> +SRC_URI = "http://fribidi.org/download/fribidi-${PV}.tar.bz2"
> +
> +SRC_URI[md5sum] = "6c7e7cfdd39c908f7ac619351c1c5c23"
> +SRC_URI[sha256sum] = "08222a6212bbc2276a2d55c3bf370109ae4a35b689acbc66571ad2a670595a8e"
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

  reply	other threads:[~2016-04-27  7:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 19:04 [meta-oe][PATCH] fribidi: update to version 0.19.7 Derek Straka
2016-04-27  7:45 ` Martin Jansa [this message]
2016-04-27  7:48   ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160427074500.GA2559@jama \
    --to=martin.jansa@gmail.com \
    --cc=derek@asterius.io \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.