Re: [PATCH] flash_eraseall: Remove warning

[Boris Brezillon <boris.brezillon@free-electrons.com>]

On Tue, 26 Apr 2016 22:03:42 +0200
Richard Weinberger <richard@nod.at> wrote:

> Well, flash_erase <mtddev> 0 0 is the same as flash_eraseall <mtddev>.
> But flash_eraseall is still more handy to use.
> Let's keep flash_eraseall as short cut and don't force users to
> use a less handy user interface.

Hm, I'm not convinced by this change. Aren't we trying to make people
switch to flash_erase instead of using flash_eraseall.
If you want to make flash_erase more easy to use, you can always erase
the whole partition if only <mtddev> is passed in arguments, which IMO
would be clearer than having to pass 0 0.

> 
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  misc-utils/flash_eraseall | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/misc-utils/flash_eraseall b/misc-utils/flash_eraseall
> index c5539b3..65a85cc 100755
> --- a/misc-utils/flash_eraseall
> +++ b/misc-utils/flash_eraseall
> @@ -1,4 +1,3 @@
>  #!/bin/sh
> -echo "${0##*/} has been replaced by \`flash_erase <mtddev> 0 0\`; please use it" 1>&2
>  [ $# -ne 0 ] && set -- "$@" 0 0
>  exec flash_erase "$@"



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com