From: Wei Liu <wei.liu2@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH for-4.7] build/xen: fix assembler instruction tests
Date: Wed, 27 Apr 2016 16:20:41 +0100 [thread overview]
Message-ID: <20160427152041.GU20763@citrix.com> (raw)
In-Reply-To: <1461768147-24374-1-git-send-email-roger.pau@citrix.com>
On Wed, Apr 27, 2016 at 04:42:27PM +0200, Roger Pau Monne wrote:
> The current test performed in order to check if the assembler supports
> certain instructions doesn't take into account the value of AFLAGS, which
> when using clang contains the option that disables the integrated assembler
> due to the lack of features.
>
> As a result of this, the current instruction tests were performed against the
> integrated assembler, but then at build time the non-integrated assembler
> was used. If both have feature-parity, this is a non-issue, but we cannot
> assume this.
>
> Fix this by passing AFLAGS in the instruction test, and including the arch
> Rules.mk makefile after AFLAGS is set.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-27 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 14:42 [PATCH for-4.7] build/xen: fix assembler instruction tests Roger Pau Monne
2016-04-27 15:20 ` Wei Liu [this message]
2016-04-28 10:38 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427152041.GU20763@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.