From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f71.google.com (mail-qg0-f71.google.com [209.85.192.71]) by kanga.kvack.org (Postfix) with ESMTP id 73A396B0253 for ; Wed, 27 Apr 2016 12:03:20 -0400 (EDT) Received: by mail-qg0-f71.google.com with SMTP id e35so14652637qge.0 for ; Wed, 27 Apr 2016 09:03:20 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id m131si2729578qke.164.2016.04.27.09.03.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Apr 2016 09:03:19 -0700 (PDT) Date: Wed, 27 Apr 2016 18:03:17 +0200 From: Andrea Arcangeli Subject: Re: [PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP enabled Message-ID: <20160427160317.GC11700@redhat.com> References: <1461758686-27157-1-git-send-email-aarcange@redhat.com> <20160427135030.GB22035@node.shutemov.name> <20160427145957.GA9217@redhat.com> <20160427151834.GC22035@node.shutemov.name> <20160427155730.GB11700@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160427155730.GB11700@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , "Li, Liang Z" , Amit Shah , Paolo Bonzini On Wed, Apr 27, 2016 at 05:57:30PM +0200, Andrea Arcangeli wrote: > couldn't do a fix as cleaner as this one for 4.6. ehm "cleaner then" If you've suggestions for a better name than PageTransCompoundMap I can respin a new patch though, I considered "CanMap" but I opted for the short version. Also I'm not really sure moving transparent_hugepage_adjust will make much sense. I mentioned it because Andres in another thread said it was suggested but the real common code knowledge is about PageTransCompoundMap only, all sort of !mmu_gfn_lpage_is_disallowed for dirty logging at 4k shadow granularity is KVM internal. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbcD0QDV (ORCPT ); Wed, 27 Apr 2016 12:03:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39910 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbcD0QDT (ORCPT ); Wed, 27 Apr 2016 12:03:19 -0400 Date: Wed, 27 Apr 2016 18:03:17 +0200 From: Andrea Arcangeli To: "Kirill A. Shutemov" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , "Li, Liang Z" , Amit Shah , Paolo Bonzini Subject: Re: [PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP enabled Message-ID: <20160427160317.GC11700@redhat.com> References: <1461758686-27157-1-git-send-email-aarcange@redhat.com> <20160427135030.GB22035@node.shutemov.name> <20160427145957.GA9217@redhat.com> <20160427151834.GC22035@node.shutemov.name> <20160427155730.GB11700@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160427155730.GB11700@redhat.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 27, 2016 at 05:57:30PM +0200, Andrea Arcangeli wrote: > couldn't do a fix as cleaner as this one for 4.6. ehm "cleaner then" If you've suggestions for a better name than PageTransCompoundMap I can respin a new patch though, I considered "CanMap" but I opted for the short version. Also I'm not really sure moving transparent_hugepage_adjust will make much sense. I mentioned it because Andres in another thread said it was suggested but the real common code knowledge is about PageTransCompoundMap only, all sort of !mmu_gfn_lpage_is_disallowed for dirty logging at 4k shadow granularity is KVM internal. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avRvx-0005Ep-BL for qemu-devel@nongnu.org; Wed, 27 Apr 2016 12:03:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avRvr-00020u-Se for qemu-devel@nongnu.org; Wed, 27 Apr 2016 12:03:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avRvr-00020M-O2 for qemu-devel@nongnu.org; Wed, 27 Apr 2016 12:03:19 -0400 Date: Wed, 27 Apr 2016 18:03:17 +0200 From: Andrea Arcangeli Message-ID: <20160427160317.GC11700@redhat.com> References: <1461758686-27157-1-git-send-email-aarcange@redhat.com> <20160427135030.GB22035@node.shutemov.name> <20160427145957.GA9217@redhat.com> <20160427151834.GC22035@node.shutemov.name> <20160427155730.GB11700@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160427155730.GB11700@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP enabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Kirill A. Shutemov" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , "Li, Liang Z" , Amit Shah , Paolo Bonzini On Wed, Apr 27, 2016 at 05:57:30PM +0200, Andrea Arcangeli wrote: > couldn't do a fix as cleaner as this one for 4.6. ehm "cleaner then" If you've suggestions for a better name than PageTransCompoundMap I can respin a new patch though, I considered "CanMap" but I opted for the short version. Also I'm not really sure moving transparent_hugepage_adjust will make much sense. I mentioned it because Andres in another thread said it was suggested but the real common code knowledge is about PageTransCompoundMap only, all sort of !mmu_gfn_lpage_is_disallowed for dirty logging at 4k shadow granularity is KVM internal.