Re: [PATCH] drm/omap: check plane size

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Apr 27, 2016 at 06:30:19PM +0300, Laurent Pinchart wrote:
> Hi Tomi,
> 
> (CC'ing Daniel)
> 
> Thank you for the patch.
> 
> On Tuesday 26 Apr 2016 13:16:42 Tomi Valkeinen wrote:
> > At the moment we don't check the plane input/output sizes, which can
> > lead to DSS HW errors when invalid values are given from the userspace.
> > 
> > Add a check so that the sizes are > 0.
> > 
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> 
> I don't think it makes sense to have an empty source or destination rectangle 
> for any driver, not just omapdrm. Shouldn't this check be added to 
> drm_atomic_plane_check() instead ?

It's perfectly legal. Just means you're supposed to turn the plane off.

> 
> > ---
> >  drivers/gpu/drm/omapdrm/omap_plane.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c
> > b/drivers/gpu/drm/omapdrm/omap_plane.c index 93ee538a99f5..fa9e5086eb65
> > 100644
> > --- a/drivers/gpu/drm/omapdrm/omap_plane.c
> > +++ b/drivers/gpu/drm/omapdrm/omap_plane.c
> > @@ -168,6 +168,12 @@ static int omap_plane_atomic_check(struct drm_plane
> > *plane, if (IS_ERR(crtc_state))
> >  		return PTR_ERR(crtc_state);
> > 
> > +	if (state->src_w == 0 || state->src_h == 0)
> > +		return -EINVAL;
> > +
> > +	if (state->crtc_w == 0 || state->crtc_h == 0)
> > +		return -EINVAL;
> > +
> >  	if (state->crtc_x < 0 || state->crtc_y < 0)
> >  		return -EINVAL;
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel