From: Dan Carpenter <dan.carpenter@oracle.com>
To: linus.walleij@linaro.org
Cc: linux-iio@vger.kernel.org
Subject: re: iio: light: new driver for the ROHM BH1780
Date: Thu, 28 Apr 2016 12:40:34 +0300 [thread overview]
Message-ID: <20160428094034.GA7255@mwanda> (raw)
Hello Linus Walleij,
This is a semi-automatic email about new static checker warnings.
The patch 1f0477f18306: "iio: light: new driver for the ROHM BH1780"
from Apr 11, 2016, leads to the following Smatch complaint:
drivers/iio/light/bh1780.c:93 bh1780_debugfs_reg_access()
error: we previously assumed 'readval' could be null (see line 86)
drivers/iio/light/bh1780.c
85
86 if (!readval)
^^^^^^^^
87 bh1780_write(bh1780, (u8)reg, (u8)writeval);
Should this be:
return bh1780_write(bh1780, (u8)reg, (u8)writeval);
88
89 ret = bh1780_read(bh1780, (u8)reg);
90 if (ret < 0)
91 return ret;
92
93 *readval = ret;
^^^^^^^^
94
95 return 0;
regards,
dan carpenter
reply other threads:[~2016-04-28 9:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428094034.GA7255@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.