From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Fabien Dessenne <fabien.dessenne@st.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Vincent Abriou <vincent.abriou@st.com>,
kernel@stlinux.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: fix pixel size of NV12 / NV16 pixel formats
Date: Thu, 28 Apr 2016 14:02:36 +0300 [thread overview]
Message-ID: <20160428110236.GB4329@intel.com> (raw)
In-Reply-To: <1461832839-5838-1-git-send-email-fabien.dessenne@st.com>
On Thu, Apr 28, 2016 at 10:40:39AM +0200, Fabien Dessenne wrote:
> With NV12, NV21, NV16 and NV61 formats, the size of one pixel from the
> UV plane (plane #1) is one byte.
>
> Indeed, these pixel formats use 4:2:x chroma subsampling: the chroma
> pixels are sampled at half the luma: for 2 pixels, there are 1 Cb +
> 1 Cr = 2 bytes.
You just said it, it's 2 bytes. NAK
> So for plane #1, the correct size is actually 1 byte per pixel.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> ---
> drivers/gpu/drm/drm_crtc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 3313f7e..572c6fa 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -5618,10 +5618,6 @@ int drm_format_plane_cpp(uint32_t format, int plane)
> case DRM_FORMAT_UYVY:
> case DRM_FORMAT_VYUY:
> return 2;
> - case DRM_FORMAT_NV12:
> - case DRM_FORMAT_NV21:
> - case DRM_FORMAT_NV16:
> - case DRM_FORMAT_NV61:
> case DRM_FORMAT_NV24:
> case DRM_FORMAT_NV42:
> return plane ? 2 : 1;
> @@ -5635,6 +5631,10 @@ int drm_format_plane_cpp(uint32_t format, int plane)
> case DRM_FORMAT_YVU422:
> case DRM_FORMAT_YUV444:
> case DRM_FORMAT_YVU444:
> + case DRM_FORMAT_NV12:
> + case DRM_FORMAT_NV21:
> + case DRM_FORMAT_NV16:
> + case DRM_FORMAT_NV61:
> return 1;
> default:
> drm_fb_get_bpp_depth(format, &depth, &bpp);
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-04-28 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 8:40 [PATCH] drm: fix pixel size of NV12 / NV16 pixel formats Fabien Dessenne
2016-04-28 11:02 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428110236.GB4329@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabien.dessenne@st.com \
--cc=kernel@stlinux.com \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.