All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Benc <jbenc@redhat.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] vxlan: fix ethernet address initialization
Date: Thu, 28 Apr 2016 12:28:19 +0200	[thread overview]
Message-ID: <20160428122819.032da3fb@griffin> (raw)
In-Reply-To: <1461837856-4316-1-git-send-email-nicolas.dichtel@6wind.com>

On Thu, 28 Apr 2016 12:04:16 +0200, Nicolas Dichtel wrote:
> Since commit 0c867c9bf84c, when the user specifies an ethernet address with
> IFLA_ADDRESS, it's overridden by vxlan_ether_setup() (rtnl_link_ops->setup
> is called in rtnetlink.c before handling IFLA_ADDRESS).
> 
> To test it:
> ip link add name vxlan1 address de:ad:de:4c:0f:c2 type vxlan id 1 group 239.0.0.10 dev eth0

Good catch, Nicholas. I wrote a lnst recipe to test tons of
combinations of vxlan settings but did not think about including also
link parameters :-(

This affects not only IFLA_ADDRESS but also IFLA_MTU, IFLA_BROADCAST
and IFLA_TXQLEN. I'll try to solve all of these.

Thanks for catching this.

 Jiri

  reply	other threads:[~2016-04-28 10:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28 10:04 [PATCH net-next] vxlan: fix ethernet address initialization Nicolas Dichtel
2016-04-28 10:28 ` Jiri Benc [this message]
2016-04-28 15:07 ` Nicolas Dichtel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160428122819.032da3fb@griffin \
    --to=jbenc@redhat.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.