From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Lukas Wunner <lukas@wunner.de>,
Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Qipeng Zha <qipeng.zha@intel.com>, Qi Zheng <qi.zheng@intel.com>,
Dave Airlie <airlied@gmail.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andreas Noever <andreas.noever@gmail.com>,
Linux PCI <linux-pci@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v4 4/4] PCI: Add runtime PM support for PCIe ports
Date: Thu, 28 Apr 2016 18:38:58 +0300 [thread overview]
Message-ID: <20160428153858.GG32610@lahna.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0h7n669VkzV23FA3YSQDFR5weWWVKrFBHF0XuCigGeMSA@mail.gmail.com>
On Thu, Apr 28, 2016 at 05:31:58PM +0200, Rafael J. Wysocki wrote:
> > Hmm, PM core calls pci_pm_runtime_resume() for PCI drivers which then
> > delegates to driver->runtime_resume() if set. However, if it is missing
> > it just returns -ENOSYS and does not put the device back to D0.
> >
> > So if I'm reading this right we actually need to provide
> > pcie_port_runtime_resume().
>
> You do, but it could just return 0.
>
> The suggestion seems to be that pm_runtime_mark_last_busy() is not
> needed as the core will invoke it anyway.
Ah, got it now. Thanks for the clarification!
next prev parent reply other threads:[~2016-04-28 15:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 9:53 [PATCH v4 0/4] PCI: Add support for suspending (including runtime) of PCIe ports Mika Westerberg
2016-04-25 9:53 ` [PATCH v4 1/4] PCI: No need to set d3cold_allowed to " Mika Westerberg
2016-04-26 20:45 ` Rafael J. Wysocki
2016-04-25 9:53 ` [PATCH v4 2/4] PCI: Move PCIe ports to D3 during suspend Mika Westerberg
2016-04-26 21:04 ` Rafael J. Wysocki
2016-04-28 11:33 ` Mika Westerberg
2016-04-28 14:25 ` Lukas Wunner
2016-04-28 15:03 ` Mika Westerberg
2016-04-25 9:53 ` [PATCH v4 3/4] ACPI / hotplug / PCI: Runtime resume bridge before rescan Mika Westerberg
2016-04-26 21:07 ` Rafael J. Wysocki
2016-04-25 9:53 ` [PATCH v4 4/4] PCI: Add runtime PM support for PCIe ports Mika Westerberg
2016-04-26 21:10 ` Rafael J. Wysocki
2016-04-28 14:22 ` Lukas Wunner
2016-04-28 15:13 ` Mika Westerberg
2016-04-28 15:31 ` Rafael J. Wysocki
2016-04-28 15:38 ` Mika Westerberg [this message]
2016-04-28 16:05 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428153858.GG32610@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=airlied@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mathias.nyman@intel.com \
--cc=qi.zheng@intel.com \
--cc=qipeng.zha@intel.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.