From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/2] drivers/video/am335x-fb: Properly point framebuffer behind palette
Date: Thu, 28 Apr 2016 16:57:16 +0200 [thread overview]
Message-ID: <20160428165716.63373476@crub> (raw)
In-Reply-To: <1461785956-30309-2-git-send-email-martin.pietryka@chello.at>
On Wed, 27 Apr 2016 21:39:16 +0200
Martin Pietryka martin.pietryka at chello.at wrote:
> The DMA was outputting the palette on the screen because the base
> for the DMA was not after the palette. In addition to that, the ceiling was
> also too high, this led that the output on the screen was shifted.
>
> NOTE: According to the TRM, even in 16/24bit mode a palette is required
> in the first 32 bytes of the framebuffer.
>
> See also:
> https://e2e.ti.com/support/arm/sitara_arm/f/791/p/234967/834483#834483
>
> "In this mode, the LCDC will assume all information is data and thus you
> need to ensure that the DMA points to the first pixel of data and not the
> first entry in the frame buffer which is the beginning of the 512 byte
> palette."
>
> Signed-off-by: Martin Pietryka <martin.pietryka@chello.at>
> Reviewed-by: Hannes Schmelzer <oe5hpm@oevsv.at>
> Tested-by: Hannes Schmelzer <oe5hpm@oevsv.at>
> ---
>
> Changes in v3: None
>
> drivers/video/am335x-fb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
appied to u-boot-video/master, thanks!
--
Anatolij
next prev parent reply other threads:[~2016-04-28 14:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 23:21 [U-Boot] [PATCH 1/2] drivers/video/am335x-fb: Add support for 16bpp format Martin Pietryka
2016-04-26 23:21 ` [U-Boot] [PATCH 2/2] drivers/video/am335x-fb: Properly point framebuffer behind palette Martin Pietryka
2016-04-27 6:43 ` Hannes Schmelzer
2016-04-27 7:31 ` Hannes Schmelzer
2016-04-27 8:36 ` Martin Pietryka
2016-04-27 9:02 ` Hannes Schmelzer
2016-04-27 9:17 ` Martin Pietryka
2016-04-27 9:16 ` [U-Boot] [PATCH 1/2] drivers/video/am335x-fb: Add support for 16bpp format Hannes Schmelzer
2016-04-27 9:42 ` [U-Boot] [PATCH v2 " Martin Pietryka
2016-04-27 10:07 ` Hannes Schmelzer
2016-04-27 19:45 ` Martin Pietryka
2016-04-27 19:39 ` [U-Boot] [PATCH v3 " Martin Pietryka
2016-04-27 19:39 ` [U-Boot] [PATCH v3 2/2] drivers/video/am335x-fb: Properly point framebuffer behind palette Martin Pietryka
2016-04-28 14:57 ` Anatolij Gustschin [this message]
2016-04-28 4:59 ` [U-Boot] [PATCH v3 1/2] drivers/video/am335x-fb: Add support for 16bpp format Hannes Schmelzer
2016-04-28 14:56 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428165716.63373476@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.