From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC v2 5/8] drm/fence: add in-fences support Date: Thu, 28 Apr 2016 20:51:24 +0300 Message-ID: <20160428175124.GG4329@intel.com> References: <20160426172049.GB2558@phenom.ffwll.local> <20160426174045.GC4329@intel.com> <20160426182346.GC2558@phenom.ffwll.local> <20160426185506.GH4329@intel.com> <20160426200505.GD2558@phenom.ffwll.local> <571FD402.6050407@google.com> <20160428143644.GA3496@joana> <20160428165619.GD4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 8125B6EDB7 for ; Thu, 28 Apr 2016 17:51:29 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Stone , dri-devel , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Linux Kernel Mailing List , Riley Andrews , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBBcHIgMjgsIDIwMTYgYXQgMDc6NDM6MTZQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUaHUsIEFwciAyOCwgMjAxNiBhdCA2OjU2IFBNLCBWaWxsZSBTeXJqw6Rsw6QK PiA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4+ICAtIGJldHRlciBm b3IgdHJhY2luZywgY2FuIGlkZW50aWZ5IHRoZSBidWZmZXIvZmVuY2UgcHJvbXB0bHkKPiA+Cj4g PiBDYW4gZmVuY2VzIGJlIHJldXNlZCBzb21laG93IHdoaWxlIHN0aWxsIGF0dGFjaGVkIHRvIGEg cGxhbmUsIG9yIGV2ZXI/Cj4gPiBUaGF0IG1pZ2h0IGNhdXNlIHNvbWUgb2RkbmVzcyBpZiB5b3Us IHNheSwgbGVhdmUgYSBmZW5jZSBhdHRhY2hlZCB0byBvbmUKPiA+IHBsYW5lIGFuZCB0aGVuIGRv IGEgbW9kZXNldCBvbiBhbm90aGVyIGNydGMgcGVyaGFwcyB3aGljaCBuZWVkcyB0byB0dXJuCj4g PiB0aGUgZmlyc3QgY3J0YyBvZmYrb24gdG8gcmVjb25maWd1cmUgc29tZXRoaW5nLgo+IAo+IEZl bmNlcyBhdXRvLWRpc2FwcGVhciBvZiBjb3Vyc2UgYW5kIGRvbid0IHN0aWNrIGFyb3VuZCB3aGVu IHlvdQo+IGR1cGxpY2F0ZSB0aGUgZHJtX3BsYW5lX3N0YXRlIGFnYWluLiBJIHN0aWxsIGRvbid0 IHJlYWxseSBnZXQgdGhlIHJlYWwKPiBjb25jZXJucyB0aG91Z2ggLi4uCgpQcm9wZXJ0aWVzIHRo YXQgbWFnaWNhbGx5IGNoYW5nZSB2YWx1ZXMgc2hvdWxkbid0IGV4aXN0IElNTy4gSSBndWVzcyBp Zgp5b3UgY291bGQgaGF2ZSB3cml0ZS1vbmx5IHByb3BlcnRpZXMgb3Igc29tZXRoaW5nIGl0IG1p Z3RoIGJlIHNlbnNpYmxlPwoKPiBJbiB0aGUgZW5kIGl0J3MgcHVyZWx5IGEgdHJhbnNwb3J0IHF1 ZXN0aW9uLCBhbmQKPiBib3RoIEFCSSBpZGVhcyB3b3JrIG91dCBzZW1hbnRpY2FsbHkgZXhhY3Rs eSB0aGUgc2FtZSBpbiB0aGUgZW5kLiBJdCdzCj4ganVzdCB0aGF0IGF0IGxlYXN0IGluIG15IG9w aW5pb24gRkVOQ0VfRkQgcHJvcCBpcyBhIGxvdCBtb3JlCj4gY29udmVuaWVudC4KPiAtRGFuaWVs Cj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3Jh dGlvbgo+ICs0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKCi0tIApW aWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbcD1Rvc (ORCPT ); Thu, 28 Apr 2016 13:51:32 -0400 Received: from mga02.intel.com ([134.134.136.20]:58822 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752371AbcD1Rvb (ORCPT ); Thu, 28 Apr 2016 13:51:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,547,1455004800"; d="scan'208";a="968585789" Date: Thu, 28 Apr 2016 20:51:24 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Daniel Vetter Cc: Gustavo Padovan , Daniel Stone , Greg Hackmann , Gustavo Padovan , Daniel Stone , Riley Andrews , dri-devel , Linux Kernel Mailing List , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , John Harrison Subject: Re: [RFC v2 5/8] drm/fence: add in-fences support Message-ID: <20160428175124.GG4329@intel.com> References: <20160426172049.GB2558@phenom.ffwll.local> <20160426174045.GC4329@intel.com> <20160426182346.GC2558@phenom.ffwll.local> <20160426185506.GH4329@intel.com> <20160426200505.GD2558@phenom.ffwll.local> <571FD402.6050407@google.com> <20160428143644.GA3496@joana> <20160428165619.GD4329@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 28, 2016 at 07:43:16PM +0200, Daniel Vetter wrote: > On Thu, Apr 28, 2016 at 6:56 PM, Ville Syrjälä > wrote: > >> - better for tracing, can identify the buffer/fence promptly > > > > Can fences be reused somehow while still attached to a plane, or ever? > > That might cause some oddness if you, say, leave a fence attached to one > > plane and then do a modeset on another crtc perhaps which needs to turn > > the first crtc off+on to reconfigure something. > > Fences auto-disappear of course and don't stick around when you > duplicate the drm_plane_state again. I still don't really get the real > concerns though ... Properties that magically change values shouldn't exist IMO. I guess if you could have write-only properties or something it migth be sensible? > In the end it's purely a transport question, and > both ABI ideas work out semantically exactly the same in the end. It's > just that at least in my opinion FENCE_FD prop is a lot more > convenient. > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- Ville Syrjälä Intel OTC