All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 3/4] examples: remove useless debug flags
Date: Thu, 28 Apr 2016 13:15:13 -0700	[thread overview]
Message-ID: <20160428201513.GA5641@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1461332640-24273-4-git-send-email-thomas.monjalon@6wind.com>

On Fri, Apr 22, 2016 at 03:43:59PM +0200, Thomas Monjalon wrote:
> The debug logs must be enabled at compile-time and run-time.
> There are also some internal flags in some examples to enable the debug
> logs of the applications. They are now enabled in debug configs and
> can be disabled thanks to the more generic logtype mechanism:
> 	rte_set_log_type(RTE_LOGTYPE_USER1, 0);
> 
> Removing these #ifdef allows to test these code branches more easily
> and avoid dead code pitfalls.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  examples/distributor/main.c     |  19 ++----
>  examples/ipsec-secgw/esp.c      |  14 ++--
>  examples/ipsec-secgw/ipsec.c    |   6 +-
>  examples/ipsec-secgw/ipsec.h    |   3 -
>  examples/l3fwd-acl/main.c       |   3 +
>  examples/packet_ordering/main.c |  18 ++---
>  examples/tep_termination/main.c |   7 +-
>  examples/tep_termination/main.h |   8 ---
>  examples/vhost/main.c           | 143 +++++++++++++++++++++-------------------
>  examples/vhost/main.h           |  12 ----
>  examples/vhost_xen/main.c       |  62 +++++++----------
>  examples/vhost_xen/main.h       |  11 ----

For the vhost example part,

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

	--yliu

  reply	other threads:[~2016-04-28 20:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 13:43 [PATCH 0/4] cleanup debug and dead code Thomas Monjalon
2016-04-22 13:43 ` [PATCH 1/4] eal: increase log level of some messages Thomas Monjalon
2016-04-22 13:43 ` [PATCH 2/4] log: increase default level to info Thomas Monjalon
2016-04-22 13:43 ` [PATCH 3/4] examples: remove useless debug flags Thomas Monjalon
2016-04-28 20:15   ` Yuanhan Liu [this message]
2016-04-22 13:44 ` [PATCH 4/4] eal: add assert macro for debug Thomas Monjalon
2016-04-22 19:51   ` Yuanhan Liu
2016-04-22 21:14     ` Thomas Monjalon
2016-04-22 22:08       ` Yuanhan Liu
2016-04-22 22:42         ` Stephen Hemminger
2016-04-29  9:04           ` Thomas Monjalon
2016-05-02 13:37 ` [PATCH 0/4] cleanup debug and dead code Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160428201513.GA5641@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.