From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw6oc-0007eQ-Bh for qemu-devel@nongnu.org; Fri, 29 Apr 2016 07:42:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aw6oQ-0004Fa-Eh for qemu-devel@nongnu.org; Fri, 29 Apr 2016 07:42:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw6oQ-0004D7-9R for qemu-devel@nongnu.org; Fri, 29 Apr 2016 07:42:22 -0400 Date: Fri, 29 Apr 2016 12:42:06 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20160429114205.GM2573@work-vm> References: <1461784125-578-1-git-send-email-dgilbert@redhat.com> <1461784125-578-3-git-send-email-dgilbert@redhat.com> <57211072.6060203@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57211072.6060203@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/4] Postcopy: Add stats on page requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com, aarcange@redhat.com, den@openvz.org, marcel.a@redhat.com * Eric Blake (eblake@redhat.com) wrote: > On 04/27/2016 01:08 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > On the source, add a count of page requests received from the > > destination. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > hmp.c | 4 +++ > > include/migration/migration.h | 2 ++ > > migration/migration.c | 59 ++++++++++++++++++------------------------- > > migration/ram.c | 1 + > > qapi-schema.json | 6 ++++- > > 5 files changed, 36 insertions(+), 36 deletions(-) > > > > > +++ b/migration/migration.c > > @@ -561,6 +561,26 @@ static void get_xbzrle_cache_stats(MigrationInfo *info) > > } > > } > > > > +static void populate_ram_info(MigrationInfo *info, MigrationState *s) > > +{ > > + info->has_ram = true; > > + info->ram = g_malloc0(sizeof(*info->ram)); > > > @@ -585,18 +605,7 @@ MigrationInfo *qmp_query_migrate(Error **errp) > > info->has_setup_time = true; > > info->setup_time = s->setup_time; > > > > - info->has_ram = true; > > - info->ram = g_malloc0(sizeof(*info->ram)); > > If you respin, please split the refactoring into one patch, and the > addition of postcopy stats in another, so that the addition is not lost > in the noise. Done. > Otherwise looks fine. Thanks. Dave > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK