From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 02/13] staging/android: drop sync_file_install() and sync_file_put()
Date: Fri, 29 Apr 2016 11:11:49 -0300 [thread overview]
Message-ID: <20160429141149.GD2524@joana> (raw)
In-Reply-To: <00dc01d1a1ef$2692b6e0$73b824a0$@alibaba-inc.com>
2016-04-29 Hillf Danton <hillf.zj@alibaba-inc.com>:
> >
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >
> > These two functions are just wrappers for one line functions, they
> > call fd_install() and fput() respectively, so just get rid of them
> > and use fd_install() and fput() directly for more simplicity.
> >
> Given sync_file is not file, I don't see that simplicity is worth of
> the change of 20+ lines.
> Can you please specify the disadvantages of the wrappers?
Our idea here was to simplify as much as possible this API, also we do
not want to hide sync_file internals from its users. This is staging
and we are re-thinking the API (and userspace ABI too) before moving it
out if staging. I can add some more information to the commit message.
Gustavo
next prev parent reply other threads:[~2016-04-29 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <00da01d1a1ed$f8d8e4a0$ea8aade0$@alibaba-inc.com>
2016-04-29 8:14 ` [PATCH v2 02/13] staging/android: drop sync_file_install() and sync_file_put() Hillf Danton
2016-04-29 14:11 ` Gustavo Padovan [this message]
2016-04-28 13:46 [PATCH v2 00/13] De-stage Sync File Framework Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 02/13] staging/android: drop sync_file_install() and sync_file_put() Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429141149.GD2524@joana \
--to=gustavo.padovan@collabora.co.uk \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.