Re: Status of RXE/Soft-RoCE driver?

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 3721 bytes --]

On Fri, Apr 29, 2016 at 11:06:46AM -0400, Doug Ledford wrote:
> On 04/29/2016 01:17 AM, Leon Romanovsky wrote:
> > On Thu, Apr 28, 2016 at 10:09:15PM -0400, Doug Ledford wrote:
> >> On 04/28/2016 10:01 AM, Or Gerlitz wrote:
> >>> On Thu, Apr 28, 2016 at 2:56 PM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> >>>> On Thu, Apr 28, 2016 at 02:17:29PM +0300, Sagi Grimberg wrote:
> >>>
> >>>>> FWIW, I'd love to see ib_rxe upstream asap. In fact, I even have
> >>>>> some patches to contribute for it.
> >>>>
> >>>> We are planning on submitting it in very near future.
> >>>
> >>> So.. lets get this going, Linus made a comment [1] that we might not
> >>> go up even till rc7, which means there very little time left, Moni?
> >>>
> >>> On a related note, is there ANY patch merged for 4.7? Doug, are we
> >>> again going to have have it in
> >>> all-patches-merged-on-the-same-night-10-days-after-the-merge-window-opened
> >>> manner?
> >>
> >> I have topic branches started.  The generic RDMA READ/WRITE API is
> >> almost ready to go once Christoph answers the last few things.  That's
> >> really the only one in queue right now that's big in terms of core
> >> changes, most of the rest of the stuff is all driver or ULP specific.
> >> The RSS patches haven't got much review yet.
> > 
> > Doug,
> > These patches are long time here in mailing list and they were reviewed as
> > all other patches in this mailing list.
> 
> That's not true.  The RSS patches in particular tend to get no review.
> No one appears to care about them.  V1 was posted way back last year and
> no one had anything to say about them.  I don't know when V2 was, it's
> no longer in my mailbox.  Then v3 has been on the list for 12 days and
> again, no one has responded.  No review at all does not mean
> automatically accepted.

I'm a little bit confused here, do I need to stop reviewing other code?
So it won't be counted as "interesting".

For example, there is no many interest in hns, NES and i40iw code, what
do we do here? Maybe we should stop to accept it too?

> 
> My slowness on the patches is that you are doing this in an obviously
> device specific way.  The only device that will support RSS this way is
> mlx5 devices.  But, I'm wondering if there isn't a more generic way to
> do this that can be done in the core or in the driver during WQE
> processing.  Maybe we can scale performance by having a more
> multithreaded process approach without resorting to firmware specific
> effects.  If that were the case, that would be my preferred way to go.
> Until I have the spare time to investigate if this approach is possible,
> it leaves these patches in limbo land.

What did you stop from express your point before?

> 
> >> The SELinux patches are in RFC stage, and IMO should be shelved until
> >> verbs 2.0 API is settled so we only have one API to apply it too,
> > 
> > SELinux code adds hooks which are deep in IB/core code and doesn't
> > play with ABI at all.
> 
> They snoop ABI.  If they ABI changes, they would possibly need to be
> changed in order to continue to be able to read the elements.

Why is it different from other IB/core code? Once it will be needed, it will be
updated together with other code.

> 
>  This is unrelated to ABI change initiative which
> > anyhow will be required to support existing IBTA specification.
> > 
> >> -- 
> >> Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >>               GPG KeyID: 0E572FDD
> >>
> >>
> > 
> > 
> 
> 
> -- 
> Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>               GPG KeyID: 0E572FDD
> 
> 



[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]