From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Thierry Bultel <tbultel@free.fr>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai] [PATCH 1/1] posix skin: fix address passed to pse51_mutex_check_init in syscall
Date: Fri, 29 Apr 2016 21:40:18 +0200 [thread overview]
Message-ID: <20160429194018.GO1881@hermes.click-hack.org> (raw)
In-Reply-To: <1461854390-27536-1-git-send-email-tbultel@free.fr>
On Thu, Apr 28, 2016 at 04:39:50PM +0200, Thierry Bultel wrote:
> The address passed to pse51_mutex_check_init was the one of userland,
> not the kernel one.
>
> Signed-off-by: Thierry Bultel <tbultel@free.fr>
> ---
> ksrc/skins/posix/syscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ksrc/skins/posix/syscall.c b/ksrc/skins/posix/syscall.c
> index 87b95fa..31e2705 100644
> --- a/ksrc/skins/posix/syscall.c
> +++ b/ksrc/skins/posix/syscall.c
> @@ -1202,7 +1202,7 @@ static int __pthread_mutex_check_init(struct pt_regs *regs)
> } else
> attr = NULL;
>
> - return pse51_mutex_check_init(&umx->shadow_mutex, attr);
> + return pse51_mutex_check_init(&mx.shadow_mutex, attr);
> }
Ah, what a coincidence, Jan reported this issue a long time ago:
https://xenomai.org/pipermail/xenomai/2015-December/035656.html
and I have merged a patch for it just a few days ago in my local
branch (soon to be Xenomai 2.6.5).
--
Gilles.
https://click-hack.org
next prev parent reply other threads:[~2016-04-29 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 14:39 [Xenomai] [PATCH 1/1] posix skin: fix address passed to pse51_mutex_check_init in syscall Thierry Bultel
2016-04-29 19:40 ` Gilles Chanteperdrix [this message]
2016-04-29 20:50 ` Thierry Bultel
2016-04-29 21:15 ` Gilles Chanteperdrix
2016-04-30 9:41 ` Thierry Bultel
2016-04-30 9:47 ` Gilles Chanteperdrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429194018.GO1881@hermes.click-hack.org \
--to=gilles.chanteperdrix@xenomai.org \
--cc=tbultel@free.fr \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.