From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH] tpm: select ANON_INODES for proxy driver Date: Fri, 29 Apr 2016 22:41:38 +0300 Message-ID: <20160429194138.GA22950@intel.com> References: <1461840382-2996256-1-git-send-email-arnd@arndb.de> <20160429184206.GA21071@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160429184206.GA21071-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Arnd Bergmann Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Fri, Apr 29, 2016 at 09:42:06PM +0300, Jarkko Sakkinen wrote: > On Thu, Apr 28, 2016 at 12:46:13PM +0200, Arnd Bergmann wrote: > > The newly added vtpmx driver fails to build if CONFIG_ANON_INODES > > is disabled: > > > > drivers/char/built-in.o: In function `vtpmx_fops_ioctl': > > (.text+0x97f8): undefined reference to `anon_inode_getfile' > > > > This adds a Kconfig 'select' statement to ensure it's always there > > when we need it. > > > > Signed-off-by: Arnd Bergmann > > Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs") > > Acked-by: Jarkko Sakkinen > > /Jarkko Applied and merge to next. /Jarkko > > --- > > drivers/char/tpm/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig > > index 0eac596e33d1..bfdc5c0486aa 100644 > > --- a/drivers/char/tpm/Kconfig > > +++ b/drivers/char/tpm/Kconfig > > @@ -125,6 +125,7 @@ config TCG_CRB > > config TCG_VTPM_PROXY > > tristate "VTPM Proxy Interface" > > depends on TCG_TPM > > + select ANON_INODES > > ---help--- > > This driver proxies for an emulated TPM (vTPM) running in userspace. > > A device /dev/vtpmx is provided that creates a device pair > > -- > > 2.7.0 > > ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752554AbcD2Tlt (ORCPT ); Fri, 29 Apr 2016 15:41:49 -0400 Received: from mga03.intel.com ([134.134.136.65]:32090 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbcD2Tls (ORCPT ); Fri, 29 Apr 2016 15:41:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,553,1455004800"; d="scan'208";a="955745765" Date: Fri, 29 Apr 2016 22:41:38 +0300 From: Jarkko Sakkinen To: Arnd Bergmann Cc: Peter Huewe , Marcel Selhorst , Jason Gunthorpe , Stefan Berger , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm: select ANON_INODES for proxy driver Message-ID: <20160429194138.GA22950@intel.com> References: <1461840382-2996256-1-git-send-email-arnd@arndb.de> <20160429184206.GA21071@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160429184206.GA21071@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 29, 2016 at 09:42:06PM +0300, Jarkko Sakkinen wrote: > On Thu, Apr 28, 2016 at 12:46:13PM +0200, Arnd Bergmann wrote: > > The newly added vtpmx driver fails to build if CONFIG_ANON_INODES > > is disabled: > > > > drivers/char/built-in.o: In function `vtpmx_fops_ioctl': > > (.text+0x97f8): undefined reference to `anon_inode_getfile' > > > > This adds a Kconfig 'select' statement to ensure it's always there > > when we need it. > > > > Signed-off-by: Arnd Bergmann > > Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs") > > Acked-by: Jarkko Sakkinen > > /Jarkko Applied and merge to next. /Jarkko > > --- > > drivers/char/tpm/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig > > index 0eac596e33d1..bfdc5c0486aa 100644 > > --- a/drivers/char/tpm/Kconfig > > +++ b/drivers/char/tpm/Kconfig > > @@ -125,6 +125,7 @@ config TCG_CRB > > config TCG_VTPM_PROXY > > tristate "VTPM Proxy Interface" > > depends on TCG_TPM > > + select ANON_INODES > > ---help--- > > This driver proxies for an emulated TPM (vTPM) running in userspace. > > A device /dev/vtpmx is provided that creates a device pair > > -- > > 2.7.0 > >