From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752409AbcD3VCo (ORCPT ); Sat, 30 Apr 2016 17:02:44 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55317 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651AbcD3VCn (ORCPT ); Sat, 30 Apr 2016 17:02:43 -0400 Date: Sat, 30 Apr 2016 14:02:42 -0700 From: Greg KH To: "K. Y. Srinivasan" Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com Subject: Re: [PATCH 1/3] Drivers: hv: balloon: don't crash when memory is added in non-sorted order Message-ID: <20160430210242.GA30882@kroah.com> References: <1461955494-32235-1-git-send-email-kys@microsoft.com> <1461955519-32276-1-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461955519-32276-1-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 29, 2016 at 11:45:17AM -0700, K. Y. Srinivasan wrote: > From: Vitaly Kuznetsov > > When we iterate through all HA regions in handle_pg_range() we have an > assumption that all these regions are sorted in the list and the > 'start_pfn >= has->end_pfn' check is enough to find the proper region. > Unfortunately it's not the case with WS2016 where host can hot-add regions > in a different order. We end up modifying the wrong HA region and crashing > later on pages online. Modify the check to make sure we found the region > we were searching for while iterating. Fix the same check in pfn_covered() > as well. > > Signed-off-by: Vitaly Kuznetsov > Signed-off-by: K. Y. Srinivasan > --- > drivers/hv/hv_balloon.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) I only received patch 1/3 here, what happened to the other 2? Can you resend the whole series? thanks, greg k-h