From: Matt Fleming <matt@codeblueprint.co.uk>
To: Shannon Zhao <shannon.zhao@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Xen Devel <Xen-devel@lists.xensource.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-next@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>
Subject: Re: efi_enabled(EFI_PARAVIRT) use
Date: Sun, 1 May 2016 14:26:20 +0100 [thread overview]
Message-ID: <20160501132620.GT2839@codeblueprint.co.uk> (raw)
In-Reply-To: <572576E2.7060508@linaro.org>
On Sun, 01 May, at 11:24:18AM, Shannon Zhao wrote:
> Because the UEFI params for Dom0 are located under /hypervisor/uefi node
> instead of /chosen. So it needs to check whether it's a Dom0 then search
> and parse different node with different params arrays.
Why can't you search both nodes? Would you ever expect to see both for
a Dom0 kernel?
> So it still needs add another check to firstly parse the fdt to see if
> there is "xen,uefi-system-table" under /hypervisor/uefi node, right? I
> think it's a bit redundant compared with xen_initial_domain().
Sometimes you really do need to check xen_initial_domain(), but I do
not think this is such a case. And if we can get by without adding
that check, the code will be better for it.
next prev parent reply other threads:[~2016-05-01 13:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 4:20 linux-next: manual merge of the xen-tip tree with the tip tree Stephen Rothwell
2016-04-29 6:39 ` efi_enabled(EFI_PARAVIRT) use Ingo Molnar
2016-04-29 6:39 ` Ingo Molnar
2016-04-29 8:25 ` Borislav Petkov
2016-04-29 9:26 ` Matt Fleming
2016-04-29 10:34 ` Stefano Stabellini
2016-04-29 10:46 ` Ingo Molnar
2016-04-29 14:39 ` Matt Fleming
2016-04-29 14:53 ` Ard Biesheuvel
2016-04-30 14:14 ` Shannon Zhao
2016-04-30 20:44 ` Matt Fleming
2016-05-01 3:24 ` Shannon Zhao
2016-05-01 13:26 ` Matt Fleming [this message]
2016-05-01 14:36 ` Shannon Zhao
2016-05-02 10:45 ` Matt Fleming
2016-05-03 1:45 ` [Xen-devel] " Shannon Zhao
2016-05-03 1:45 ` Shannon Zhao
2016-05-04 11:36 ` Matt Fleming
2016-05-03 9:13 ` Shannon Zhao
2016-05-03 9:13 ` Shannon Zhao
2016-04-29 14:58 ` Stefano Stabellini
2016-04-29 15:37 ` Stefano Stabellini
2016-04-30 14:04 ` Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160501132620.GT2839@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=Xen-devel@lists.xensource.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=shannon.zhao@linaro.org \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.