From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sun, 1 May 2016 09:46:20 -0400 Subject: [U-Boot] spl_mmc: allow to load raw image In-Reply-To: References: <1456745517-19797-1-git-send-email-yamada.masahiro@socionext.com> <20160317020452.GX23166@bill-the-cat> <20160317161210.GB23166@bill-the-cat> <20160429175350.GZ19598@bill-the-cat> Message-ID: <20160501134620.GD7884@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, May 01, 2016 at 05:37:42PM +0900, Masahiro Yamada wrote: > Hi Adam, > > > 2016-04-30 3:06 GMT+09:00 Adam Ford : > > On Fri, Apr 29, 2016 at 12:53 PM, Tom Rini wrote: > >> On Fri, Apr 29, 2016 at 09:59:00AM -0500, Adam Ford wrote: > >> > >>> Does anyone with an OMAP3 board have any issues with this patch? I > >>> will admit I haven't stayed on top of stuff due to moving, and other > >>> issues at home, but I pulled down the master to reviews some on > >>> related stuff, and found that master doesn't boot. I used git bisect > >>> this morning and it narrowed down a problem with booting to this > >>> patch. > >>> > >>> With the patch, I get: > >>> > >>> U-Boot SPL 2016.03-00378-g4976f48 (Apr 29 2016 - 09:25:27) > >>> Trying to boot from MMC > >> > >> OK. Do you have u-boot.bin or u-boot.img (which?) written to the raw > >> offset in MMC or from filesystem? Based on the log it looks like > >> filesystem. > > > > I have u-boot.img copied to the fatfs on the card, but I didn't put it > > in a specific location. > > > > I never used to have to do that. Is this a new behavior and is it > > documented somewhere? > > > > adam > > > You are expecting to boot it from FAT, > but I think spl_boot_mode() on your board returns MMCSD_MODE_RAW. > > Can you fix the function to return MMCSD_MODE_FS? > > > > This commit changed to allow to load raw U-Boot image, > so MMCSD_MODE_RAW never fails. > > So, you can no longer rely on the former behavior > "try MMCSD_MODE_RAW first, and fallback to MMCSD_MODE_FS". Well, I forgot to ask, is MLO being loaded from FAT or from raw? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: