From: David Sterba <dsterba@suse.cz>
To: "Güngör Erseymen" <gelurine@gmail.com>
Cc: Liu Bo <bo.li.liu@oracle.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix divide error upon chunk's stripe_len
Date: Mon, 2 May 2016 10:16:44 +0200 [thread overview]
Message-ID: <20160502081644.GF29353@suse.cz> (raw)
In-Reply-To: <877ffgp7g2.fsf@gmail.com>
On Fri, Apr 29, 2016 at 09:59:25PM +0300, Güngör Erseymen wrote:
> > --- a/fs/btrfs/volumes.h
> > +++ b/fs/btrfs/volumes.h
> > @@ -347,7 +347,7 @@ struct map_lookup {
> > u64 type;
> > int io_align;
> > int io_width;
> > - int stripe_len;
> > + u64 stripe_len;
> > int sector_size;
> > int num_stripes;
> > int sub_stripes;
> > --
> > 2.5.0
>
> Type change of map->stripe_len to u64 cause build error "undefined
> reference to __udivdi3" on 32bit systems. Using explicit 64 bit division
> fixes it and would be better to combine into this commit for
> continuity.
Done, thanks for the report.
JFYI, the branches pushed to kernel.org get automated build tests so I
get the email reports from kbuild eventually.
prev parent reply other threads:[~2016-05-02 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 0:53 [PATCH] Btrfs: fix divide error upon chunk's stripe_len Liu Bo
2016-04-27 16:39 ` David Sterba
2016-04-27 17:23 ` Liu Bo
2016-04-27 17:33 ` David Sterba
2016-04-28 17:48 ` Liu Bo
2016-04-29 3:20 ` Qu Wenruo
2016-04-29 17:09 ` Liu Bo
2016-04-29 16:22 ` David Sterba
[not found] ` <877ffgp7g2.fsf@gmail.com>
2016-04-30 4:09 ` Liu Bo
2016-05-02 8:16 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502081644.GF29353@suse.cz \
--to=dsterba@suse.cz \
--cc=bo.li.liu@oracle.com \
--cc=gelurine@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.