All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] xsplice: Missing if ( sec )
Date: Mon, 2 May 2016 14:09:16 +0100	[thread overview]
Message-ID: <20160502130916.GU26957@citrix.com> (raw)
In-Reply-To: <1462194334-2761-1-git-send-email-konrad.wilk@oracle.com>

On Mon, May 02, 2016 at 09:05:34AM -0400, Konrad Rzeszutek Wilk wrote:
> Add the missing conditional.
> 
> Reported-by: Jan Beulich <JBeulich@suse.com>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 

FWIW:

Reviewed-by: Wei Liu <wei.liu2@citrix.com>

And subject to ack from HV maintainer:

Release-acked-by: Wei Liu <wei.liu2@citrix.com>

> ---
> This has been in there since v3 posting! And I really need to finish
> with the OSSTest regression tests to catch this.
> 
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
>  xen/common/xsplice.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c
> index 777faa7..c9fc53a 100644
> --- a/xen/common/xsplice.c
> +++ b/xen/common/xsplice.c
> @@ -548,6 +548,7 @@ static int prepare_payload(struct payload *payload,
>      }
>  
>      sec = xsplice_elf_sec_by_name(elf, ELF_XSPLICE_DEPENDS);
> +    if ( sec )
>      {
>          n = sec->load_addr;
>  
> -- 
> 2.5.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-05-02 13:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-02 13:05 [PATCH] xsplice: Missing if ( sec ) Konrad Rzeszutek Wilk
2016-05-02 13:09 ` Wei Liu [this message]
2016-05-02 13:15   ` Jan Beulich
2016-05-02 13:15   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160502130916.GU26957@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.