From: Wei Liu <wei.liu2@citrix.com>
To: "Lai, Paul C" <paul.c.lai@intel.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: Patch to honor --enable-githttp
Date: Mon, 2 May 2016 18:02:45 +0100 [thread overview]
Message-ID: <20160502170245.GA15158@citrix.com> (raw)
In-Reply-To: <8CA46881B83C354B99AD61C20C93EB1BD509CF@ORSMSX109.amr.corp.intel.com>
Hello, thanks for the patch
On Mon, May 02, 2016 at 04:36:48PM +0000, Lai, Paul C wrote:
> The following patch fixes the toplevel Xen makefile gereration to honor -enable-githttp if the option is used during configuration.
>
>
> commit 040510913564ec7e9f46ce833f8bdf1a40950ff7
> Author: Paul Lai <paul.c.lai@intel.com>
> Date: Mon Apr 11 10:43:57 2016 -0700
>
> Honor '--enable-githttp' in toplevel Makefile generation
>
> During the make world, git mini-os.git didn't honor the 'configure
> --enable-githttp' option. The 'enable-githttp' was only honored in
> the tools subdirectory.
>
It is required that you sign off the patch you submit.
It's also a good practice to CC maintainers so that they don't miss your
patch.
Please have a look at
http://wiki.xen.org/wiki/Submitting_Xen_Project_Patches
which has a lot of things covered.
> diff --git a/config/Toplevel.mk.in b/config/Toplevel.mk.in
> index 4db7eaf..1d99189 100644
> --- a/config/Toplevel.mk.in
> +++ b/config/Toplevel.mk.in
> @@ -1 +1,2 @@
> SUBSYSTEMS := @SUBSYSTEMS@
> +GIT_HTTP := @githttp@
The indentation seems wrong. Not sure if it is due to my mail messing
things up though.
Anyway, please resubmit with proper SoB and I will have a closer look.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-02 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 16:36 Patch to honor --enable-githttp Lai, Paul C
2016-05-02 17:02 ` Wei Liu [this message]
2016-05-04 9:41 ` Wei Liu
2016-05-04 16:05 ` Lai, Paul C
2016-05-04 16:18 ` Wei Liu
2016-05-04 17:25 ` Lai, Paul C
-- strict thread matches above, loose matches on Subject: below --
2016-05-02 15:55 Paul Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502170245.GA15158@citrix.com \
--to=wei.liu2@citrix.com \
--cc=paul.c.lai@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.