From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v2] virtio: fix modify drv_flags for specific device Date: Mon, 2 May 2016 10:55:30 -0700 Message-ID: <20160502175530.GO5641@yliu-dev.sh.intel.com> References: <1461637474-110602-1-git-send-email-jianfeng.tan@intel.com> <1461866939-38689-1-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, huawei.xie@intel.com, david.marchand@6wind.com To: Jianfeng Tan Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4F54337B6 for ; Mon, 2 May 2016 19:52:22 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1461866939-38689-1-git-send-email-jianfeng.tan@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 28, 2016 at 06:08:59PM +0000, Jianfeng Tan wrote: > Issue: virtio's drv_flags are decided by devices types (modern vs legacy), > and which kernel driver is used, and the negotiated features (especially > VIRTIO_NET_STATUS) with backend, which makes it possible to multiple > virtio devices have different versions of drv_flags, but this variable > is currently shared by each virtio device. > > How to fix: dev_flags is a device-specific variable to store this info. > > Fixes: da978dfdc43 ("virtio: use port IO to get PCI resource") > > Reported-by: David Marchand > Suggested-by: David Marchand Hi David, May I ask your review on this and give ACK when no issue to you? Thanks. --yliu