From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH 01/12] staging/android: remove redundant comments on sync_merge_data Date: Mon, 2 May 2016 18:11:51 -0300 Message-ID: <20160502211151.GA2531@joana> References: <1461774439-11512-1-git-send-email-gustavo@padovan.org> <1461774439-11512-2-git-send-email-gustavo@padovan.org> <20160502210007.GA2397@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-f194.google.com (mail-yw0-f194.google.com [209.85.161.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 60E606E35A for ; Mon, 2 May 2016 21:11:56 +0000 (UTC) Received: by mail-yw0-f194.google.com with SMTP id v81so48375ywa.2 for ; Mon, 02 May 2016 14:11:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160502210007.GA2397@amd> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Pavel Machek Cc: devel@driverdev.osuosl.org, Daniel Stone , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Daniel Vetter , Riley Andrews , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org MjAxNi0wNS0wMiBQYXZlbCBNYWNoZWsgPHBhdmVsQHVjdy5jej46Cgo+IE9uIFdlZCAyMDE2LTA0 LTI3IDEzOjI3OjA4LCBHdXN0YXZvIFBhZG92YW4gd3JvdGU6Cj4gPiBGcm9tOiBHdXN0YXZvIFBh ZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY28udWs+Cj4gPiAKPiA+IHN0cnVjdCBz eW5jX21lcmdlX2RhdGEgYWxyZWFkeSBoYXZlIGRvY3VtZW50YXRpb24gb24gdG9wIG9mIHRoZQo+ ID4gc3RydWN0IGRlZmluaXRpb24uIE5vIG5lZWQgdG8gZHVwbGljYXRlIGl0Lgo+ID4gCj4gPiBT aWduZWQtb2ZmLWJ5OiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEu Y28udWs+Cj4gPiBSZXZpZXdlZC1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hv cnN0QGxpbnV4LmludGVsLmNvbT4KPiAKPiA+IEBAIC0zMyw4ICszMyw4IEBAIHN0cnVjdCBzeW5j X21lcmdlX2RhdGEgewo+ID4gIC8qKgo+ID4gICAqIHN0cnVjdCBzeW5jX2ZlbmNlX2luZm8gLSBk ZXRhaWxlZCBmZW5jZSBpbmZvcm1hdGlvbgo+ID4gICAqIEBvYmpfbmFtZToJCW5hbWUgb2YgcGFy ZW50IHN5bmNfdGltZWxpbmUKPiA+IC0gKiBAZHJpdmVyX25hbWU6CW5hbWUgb2YgZHJpdmVyIGlt cGxlbWVudGluZyB0aGUgcGFyZW50Cj4gPiAtICogQHN0YXR1czoJCXN0YXR1cyBvZiB0aGUgZmVu Y2UgMDphY3RpdmUgMTpzaWduYWxlZCA8MDplcnJvcgo+ID4gKyogQGRyaXZlcl9uYW1lOgluYW1l IG9mIGRyaXZlciBpbXBsZW1lbnRpbmcgdGhlIHBhcmVudAo+ID4gKyogQHN0YXR1czoJCXN0YXR1 cyBvZiB0aGUgZmVuY2UgMDphY3RpdmUgMTpzaWduYWxlZCA8MDplcnJvcgo+IAo+IFRoZSB3aGl0 ZXNwYWNlIChvciBtYWlsIGNsaWVudCBjb25maWd1cmF0aW9uPykgbG9va3Mgd3JvbmcgaGVyZS4K CnRoaXMgaGFzIGJlZW4gZml4ZWQgaW4gdjIgYWxyZWFkeSBhbmQgR3JlZyBwdWxsZWQgZXZlcnl0 aGluZyBpbnRvCnN0YWdpbmcgbmV4dCBhbHJlYWR5LgoKCUd1c3Rhdm8KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932182AbcEBVMF (ORCPT ); Mon, 2 May 2016 17:12:05 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:32870 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755025AbcEBVL4 (ORCPT ); Mon, 2 May 2016 17:11:56 -0400 Date: Mon, 2 May 2016 18:11:51 -0300 From: Gustavo Padovan To: Pavel Machek Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Sumit Semwal , Gustavo Padovan Subject: Re: [PATCH 01/12] staging/android: remove redundant comments on sync_merge_data Message-ID: <20160502211151.GA2531@joana> Mail-Followup-To: Gustavo Padovan , Pavel Machek , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Maarten Lankhorst , Sumit Semwal , Gustavo Padovan References: <1461774439-11512-1-git-send-email-gustavo@padovan.org> <1461774439-11512-2-git-send-email-gustavo@padovan.org> <20160502210007.GA2397@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160502210007.GA2397@amd> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-05-02 Pavel Machek : > On Wed 2016-04-27 13:27:08, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > struct sync_merge_data already have documentation on top of the > > struct definition. No need to duplicate it. > > > > Signed-off-by: Gustavo Padovan > > Reviewed-by: Maarten Lankhorst > > > @@ -33,8 +33,8 @@ struct sync_merge_data { > > /** > > * struct sync_fence_info - detailed fence information > > * @obj_name: name of parent sync_timeline > > - * @driver_name: name of driver implementing the parent > > - * @status: status of the fence 0:active 1:signaled <0:error > > +* @driver_name: name of driver implementing the parent > > +* @status: status of the fence 0:active 1:signaled <0:error > > The whitespace (or mail client configuration?) looks wrong here. this has been fixed in v2 already and Greg pulled everything into staging next already. Gustavo