From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932200AbcEBVzJ (ORCPT ); Mon, 2 May 2016 17:55:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56523 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755173AbcEBVzG (ORCPT ); Mon, 2 May 2016 17:55:06 -0400 Date: Mon, 2 May 2016 14:55:05 -0700 From: Greg KH To: Patryk Mezydlo Cc: lidza.louina@gmail.com, mwelling@ieee.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: dgnc: fix coding style warning in dgnc_cls.c Message-ID: <20160502215505.GB16158@kroah.com> References: <20160502210715.GA1214@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160502210715.GA1214@debian> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 02, 2016 at 11:07:15PM +0200, Patryk Mezydlo wrote: > This is a patch to the dgnc_cls.c file that fixes up a brace > warning found by the checkpatch.pl tool > > Signed-off-by: Patryk Mezydlo > --- > drivers/staging/dgnc/dgnc_cls.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c > index 5e46ac8..f782904 100644 > --- a/drivers/staging/dgnc/dgnc_cls.c > +++ b/drivers/staging/dgnc/dgnc_cls.c > @@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t *ch) > /* Clear out UART and FIFO */ > readb(&ch->ch_cls_uart->txrx); > > - writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT), > + writeb((UART_FCR_ENABLE_FIFO > + | UART_FCR_CLEAR_RCVR > + | UART_FCR_CLEAR_XMIT), > &ch->ch_cls_uart->isr_fcr); > + This isn't a "brace warning" fix. And why add another blank line?