All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
Cc: linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] metag: Fix atomic_*_return inline asm constraints
Date: Tue, 3 May 2016 10:52:46 +0200	[thread overview]
Message-ID: <20160503085246.GK3430@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1462264859-26544-1-git-send-email-james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>

On Tue, May 03, 2016 at 09:40:59AM +0100, James Hogan wrote:
> The argument i of atomic_*_return() operations is given to inline asm
> with the "bd" constraint, which means "An Op2 register where Op1 is a
> data unit register and the instruction supports O2R", however Op1 is
> constrained by "da" which allows an address unit register to be used.
> 
> Fix the constraint to use "br", meaning "An Op2 register and the
> instruction supports O2R", i.e. not requiring Op1 to be a data unit
> register.
> 
> Fixes: d6dfe2509da9 ("locking,arch,metag: Fold atomic_ops")
> Signed-off-by: James Hogan <james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
> Cc: Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
> Cc: linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

Thanks James, I'd give an ack, but I really don't know about these funny
constraints you have, so I'm not sure it'd actually mean something.


  parent reply	other threads:[~2016-05-03  8:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03  8:40 [PATCH] metag: Fix atomic_*_return inline asm constraints James Hogan
     [not found] ` <1462264859-26544-1-git-send-email-james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2016-05-03  8:52   ` Peter Zijlstra [this message]
     [not found]     ` <20160503085246.GK3430-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2016-05-03  8:54       ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160503085246.GK3430@twins.programming.kicks-ass.net \
    --to=peterz-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
    --cc=james.hogan-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org \
    --cc=linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.