From: Dan Carpenter <dan.carpenter@oracle.com>
To: johannes.berg@intel.com
Cc: linux-wireless@vger.kernel.org
Subject: re: iwlwifi: add the MVM driver
Date: Tue, 3 May 2016 14:52:32 +0300 [thread overview]
Message-ID: <20160503115232.GA11129@mwanda> (raw)
Hello Johannes Berg,
The patch 8ca151b568b6: "iwlwifi: add the MVM driver" from Jan 24,
2013, leads to the following static checker warning:
drivers/net/wireless/intel/iwlwifi/mvm/d3.c:2080 __iwl_mvm_resume()
error: uninitialized symbol 'd3_status'.
drivers/net/wireless/intel/iwlwifi/mvm/d3.c
2057 static int __iwl_mvm_resume(struct iwl_mvm *mvm, bool test)
2058 {
2059 struct ieee80211_vif *vif = NULL;
2060 int ret = 1;
2061 enum iwl_d3_status d3_status;
2062 bool keep = false;
2063 bool unified_image = fw_has_capa(&mvm->fw->ucode_capa,
2064 IWL_UCODE_TLV_CAPA_CNSLDTD_D3_D0_IMG);
2065
2066 u32 flags = CMD_ASYNC | CMD_HIGH_PRIO | CMD_SEND_IN_IDLE |
2067 CMD_WAKE_UP_TRANS;
2068
2069 mutex_lock(&mvm->mutex);
2070
2071 /* get the BSS vif pointer again */
2072 vif = iwl_mvm_get_bss_vif(mvm);
2073 if (IS_ERR_OR_NULL(vif))
2074 goto err;
2075
2076 ret = iwl_trans_d3_resume(mvm->trans, &d3_status, test, !unified_image);
iwl_trans_d3_resume() just calls a resume() function pointer, but if
that pointer is NULL then it's a no-op.
2077 if (ret)
2078 goto err;
2079
2080 if (d3_status != IWL_D3_STATUS_ALIVE) {
^^^^^^^^^
This would still be uninitialized.
2081 IWL_INFO(mvm, "Device was reset during suspend\n");
2082 goto err;
2083 }
regards,
dan carpenter
next reply other threads:[~2016-05-03 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 11:52 Dan Carpenter [this message]
2016-05-03 13:08 ` iwlwifi: add the MVM driver Bjørn Mork
-- strict thread matches above, loose matches on Subject: below --
2013-02-05 8:04 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503115232.GA11129@mwanda \
--to=dan.carpenter@oracle.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.