Re: [PATCH v3 1/2] drm: bridge: Add sii902x driver

From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Jianwei Wang <jianwei.wang.chn@gmail.com>,
	Meng Yi <meng.yi@nxp.com>,
	Xiubo Li <lixiubo@cmss.chinamobile.com>,
	Emil Velikov <emil.l.velikov@gmail.com>,
	Alison Wang <alison.wang@nxp.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH v3 1/2] drm: bridge: Add sii902x driver
Date: Tue, 3 May 2016 12:03:08 +0200	[thread overview]
Message-ID: <20160503120308.269cd9a7@bbrezillon> (raw)
In-Reply-To: <CAKMK7uHCKbLN=pddNQPcYQDTMtjovF8-tb64=YqHkp0C7mFRWA@mail.gmail.com>

On Tue, 3 May 2016 11:53:18 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Tue, May 3, 2016 at 11:39 AM, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
> >> > +   .detect = sii902x_connector_detect,
> >> > +   .fill_modes = drm_helper_probe_single_connector_modes,
> >> > +   .destroy = sii902x_connector_destroy,
> >> > +};  
> >>
> >> I'm guessing this is to support both atomic and !atomic drivers. I
> >> thought it was working automatically?  
> >
> > Hm, the dw-hdmi driver is providing both, but maybe it's not needed.
> > Daniel, any comments?  
> 
> You only need this in case you actually have atomic and !atomic users
> of your bridge. We discussed whether we should have a dpms helper that
> dtrt automatically, but with just 1 driver that doesn't seem worth it.
> You wouldn't need to have 2 entier vfunc tables, you could just switch
> on DRIVER_ATOMIC.

Ok, I'll drop the !atomic helpers. Should I still test
drm_core_check_feature(drm, DRIVER_ATOMIC) in the ->attach()
implementation and return an error if the DRM device does not support
atomic operations?

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel