All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: david.spinadel@intel.com
Cc: linux-wireless@vger.kernel.org
Subject: re: iwlwifi: mvm: support sched scan if supported by the fw
Date: Tue, 3 May 2016 15:03:34 +0300	[thread overview]
Message-ID: <20160503120334.GA2258@mwanda> (raw)

Hello David Spinadel,

The patch 35a000b7c1bb: "iwlwifi: mvm: support sched scan if
supported by the fw" from Aug 28, 2013, leads to the following static
checker warning:

	drivers/net/wireless/intel/iwlwifi/mvm/scan.c:572 iwl_mvm_lmac_scan_abort()
	error: uninitialized symbol 'status'.

drivers/net/wireless/intel/iwlwifi/mvm/scan.c
   560  static int iwl_mvm_lmac_scan_abort(struct iwl_mvm *mvm)
   561  {
   562          int ret;
   563          struct iwl_host_cmd cmd = {
   564                  .id = SCAN_OFFLOAD_ABORT_CMD,
   565          };
   566          u32 status;
   567  
   568          ret = iwl_mvm_send_cmd_status(mvm, &cmd, &status);
   569          if (ret)
   570                  return ret;
   571  
   572          if (status != CAN_ABORT_STATUS) {
                    ^^^^^^

There is a "success" path in iwl_mvm_send_cmd_status() where we don't
set status.  It's commented inside the function.

   573                  /*
   574                   * The scan abort will return 1 for success or
   575                   * 2 for "failure".  A failure condition can be
   576                   * due to simply not being in an active scan which
   577                   * can occur if we send the scan abort before the
   578                   * microcode has notified us that a scan is completed.
   579                   */
   580                  IWL_DEBUG_SCAN(mvm, "SCAN OFFLOAD ABORT ret %d.\n", status);
   581                  ret = -ENOENT;
   582          }
   583  
   584          return ret;
   585  }

regards,
dan carpenter

                 reply	other threads:[~2016-05-03 12:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160503120334.GA2258@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=david.spinadel@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.