From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f200.google.com (mail-pf0-f200.google.com [209.85.192.200]) by kanga.kvack.org (Postfix) with ESMTP id 944156B0253 for ; Tue, 3 May 2016 16:28:59 -0400 (EDT) Received: by mail-pf0-f200.google.com with SMTP id 77so61589251pfz.3 for ; Tue, 03 May 2016 13:28:59 -0700 (PDT) Received: from mga09.intel.com (mga09.intel.com. [134.134.136.24]) by mx.google.com with ESMTP id t25si231459pfa.5.2016.05.03.13.28.58 for ; Tue, 03 May 2016 13:28:58 -0700 (PDT) Date: Tue, 3 May 2016 14:28:57 -0600 From: Ross Zwisler Subject: Re: [PATCH mmotm] radix-tree: rewrite radix_tree_locate_item fix Message-ID: <20160503202857.GA3997@linux.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Hugh Dickins Cc: Andrew Morton , Matthew Wilcox , Ross Zwisler , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Sun, May 01, 2016 at 09:13:18PM -0700, Hugh Dickins wrote: > radix_tree_locate_item() is often returning the wrong index, causing > swapoff of shmem to hang because it cannot find the swap entry there. > __locate()'s use of base is bogus, it adds an offset twice into index. > > Signed-off-by: Hugh Dickins Thank you for the fix! Reviewed-by: Ross Zwisler -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756621AbcECU3H (ORCPT ); Tue, 3 May 2016 16:29:07 -0400 Received: from mga03.intel.com ([134.134.136.65]:2355 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756345AbcECU3E (ORCPT ); Tue, 3 May 2016 16:29:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,574,1455004800"; d="scan'208";a="696327881" Date: Tue, 3 May 2016 14:28:57 -0600 From: Ross Zwisler To: Hugh Dickins Cc: Andrew Morton , Matthew Wilcox , Ross Zwisler , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH mmotm] radix-tree: rewrite radix_tree_locate_item fix Message-ID: <20160503202857.GA3997@linux.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 01, 2016 at 09:13:18PM -0700, Hugh Dickins wrote: > radix_tree_locate_item() is often returning the wrong index, causing > swapoff of shmem to hang because it cannot find the swap entry there. > __locate()'s use of base is bogus, it adds an offset twice into index. > > Signed-off-by: Hugh Dickins Thank you for the fix! Reviewed-by: Ross Zwisler